> 2020年3月20日 下午7:05，Nicolas George 写道：
>
> Steven Liu (12020-03-20):
>> Do you mean,
>
> I mean you should only propose code that actually does something. That
> should be easy to understand: if you store into a variable without using
> the value, remove it; then iterate.
Ok, I get it,
Steven Liu (12020-03-20):
> Do you mean,
I mean you should only propose code that actually does something. That
should be easy to understand: if you store into a variable without using
the value, remove it; then iterate.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
> 2020年3月20日 下午6:51，Nicolas George 写道：
>
> Steven Liu (12020-03-20):
>> Why the specification add these attributes into the documents if these
>> attributes not useful, just kidding?
>> I said I’m not the specification author.
>
> What Anton and I are trying to explain to you is that either
Steven Liu (12020-03-20):
> Why the specification add these attributes into the documents if these
> attributes not useful, just kidding?
> I said I’m not the specification author.
What Anton and I are trying to explain to you is that either your code
handles the attributes according to the
> 2020年3月20日 下午4:34，Anton Khirnov 写道：
>
> Quoting Steven Liu (2020-03-19 00:30:52)
>>
>> Thanks
>>
>> Steven Liu
>>
>>> 2020年3月19日 上午12:48，Andreas Rheinhardt 写道：
>>>
>>> Hello,
>>>
>>> before the actual review I want to tell you that I actually agree with
>>> Nicholas. I don't see the
Quoting Steven Liu (2020-03-19 00:30:52)
>
> Thanks
>
> Steven Liu
>
> > 2020年3月19日 上午12:48，Andreas Rheinhardt 写道：
> >
> > Hello,
> >
> > before the actual review I want to tell you that I actually agree with
> > Nicholas. I don't see the point of already parsing stuff that is not
> > used
Steven Liu (12020-03-17):
> These member will be used for get more correct information of the MPD
>
> Signed-off-by: Steven Liu
> ---
> libavformat/dashdec.c | 134 +-
> 1 file changed, 107 insertions(+), 27 deletions(-)
>
> diff --git
Thanks
Steven Liu
> 2020年3月19日 上午12:48，Andreas Rheinhardt 写道：
>
> Hello,
>
> before the actual review I want to tell you that I actually agree with
> Nicholas. I don't see the point of already parsing stuff that is not
> used yet, especially if it involves allocations and checks.
Yes, I
Hello,
before the actual review I want to tell you that I actually agree with
Nicholas. I don't see the point of already parsing stuff that is not
used yet, especially if it involves allocations and checks.
Steven Liu:
> These member will be used for get more correct information of the MPD
>
>
These member will be used for get more correct information of the MPD
Signed-off-by: Steven Liu
---
libavformat/dashdec.c | 134 +-
1 file changed, 107 insertions(+), 27 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index
10 matches
Mail list logo
