Re: [FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-19 Thread Idan Freiberg
Oh i didn't notice that. Thanks. On Mon, Jan 18, 2021 at 8:22 PM Paul B Mahol wrote: > Isn't this applied already? > > On Mon, Jan 18, 2021 at 6:46 PM Idan Freiberg wrote: > > > Can one of the maintainers review the patch please? > > > > בתאריך יום ד׳, 13 בינו׳ 2021 ב-14:35 מאת Idan Freiberg >

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-18 Thread Paul B Mahol
Isn't this applied already? On Mon, Jan 18, 2021 at 6:46 PM Idan Freiberg wrote: > Can one of the maintainers review the patch please? > > בתאריך יום ד׳, 13 בינו׳ 2021 ב-14:35 מאת Idan Freiberg : > > > DAV files may contain a variable length padding in between chunks > > filled with 0xff bytes.

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-18 Thread Idan Freiberg
Can one of the maintainers review the patch please? בתאריך יום ד׳, 13 בינו׳ 2021 ב-14:35 מאת Idan Freiberg : > DAV files may contain a variable length padding in between chunks > filled with 0xff bytes. The current skipping logic is incorrect as it > may skip over DHAV chunks not appearing sequen

[FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-13 Thread Idan Freiberg
DAV files may contain a variable length padding in between chunks filled with 0xff bytes. The current skipping logic is incorrect as it may skip over DHAV chunks not appearing sequentially in the file. We now look for the 'DHAV' tag using a byte-by-byte search in order to handle such situations. A