Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-04-06 Thread Carl Eugen Hoyos
2019-03-19 18:11 GMT+01:00, swarajhota...@gmail.com : > From: Swaraj Hota > > Fixes ticket #4519. > --- > This is my qualification task for GSoC 2019. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-26 Thread Carl Eugen Hoyos
2019-03-26 12:28 GMT+01:00, Moritz Barsnick : > On Tue, Mar 26, 2019 at 11:22:58 +0100, Carl Eugen Hoyos wrote: >> > While trying to see if the proposed XV demuxer[1] can be simplified, I >> > tripped over the fact that this KUX patch introduces a new demuxer for >> > what looks like "only" a

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-26 Thread Moritz Barsnick
On Tue, Mar 26, 2019 at 11:22:58 +0100, Carl Eugen Hoyos wrote: > > While trying to see if the proposed XV demuxer[1] can be simplified, I > > tripped over the fact that this KUX patch introduces a new demuxer for > > what looks like "only" a minor variant of FLV. Could the patch not just > > as

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-26 Thread Moritz Barsnick
On more remark: On Tue, Mar 19, 2019 at 22:41:32 +0530, swarajhota...@gmail.com wrote: > +static int kux_probe(AVProbeData *p) I get a warning if this isn't declared "const AVProbeData *p". Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-26 Thread Carl Eugen Hoyos
2019-03-26 11:18 GMT+01:00, Moritz Barsnick : > On Tue, Mar 26, 2019 at 00:24:40 +0100, Carl Eugen Hoyos wrote: >> > Fixes ticket #4519. >> I will push this if there are no objections. > > While trying to see if the proposed XV demuxer[1] can be simplified, I > tripped over the fact that this KUX

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-26 Thread Moritz Barsnick
On Tue, Mar 26, 2019 at 00:24:40 +0100, Carl Eugen Hoyos wrote: > > Fixes ticket #4519. > I will push this if there are no objections. While trying to see if the proposed XV demuxer[1] can be simplified, I tripped over the fact that this KUX patch introduces a new demuxer for what looks like

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-25 Thread Carl Eugen Hoyos
2019-03-19 18:11 GMT+01:00, swarajhota...@gmail.com : > From: Swaraj Hota > > Fixes ticket #4519. I will push this if there are no objections. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-23 Thread Swaraj Hota
Oh, I really wished to do it ':D Anyway, thanks :) Tell me if any other change can be made. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-22 Thread Carl Eugen Hoyos
2019-03-22 19:29 GMT+01:00, Swaraj Hota : > I have the meta chunk loaded into a buffer. > I searched a lot but I couldn't find a way to decompress > a password protected zip buffer. > > I saw zlib is used in the code base, so went through it. > Found a function "decompress()" but it didn't take a

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-22 Thread Swaraj Hota
Okay I found "fmemopen()". I'll see if I can use it with unzOpenCurrentFilePassword(). Please do tell if there is a better solution though. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-22 Thread Swaraj Hota
I have the meta chunk loaded into a buffer. I searched a lot but I couldn't find a way to decompress a password protected zip buffer. I saw zlib is used in the code base, so went through it. Found a function "decompress()" but it didn't take a password as argument. I found another function under

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-21 Thread Carl Eugen Hoyos
2019-03-21 21:41 GMT+01:00, Swaraj Hota : > The title is in unicode so I guess we can just encode it to utf8. > I can write a simple C code to do that. > What should I change in the patch though regarding this? > Can you give me more details on what exactly to implement? There is metadata in

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-21 Thread Swaraj Hota
The title is in unicode so I guess we can just encode it to utf8. I can write a simple C code to do that. What should I change in the patch though regarding this? Can you give me more details on what exactly to implement? ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-20 Thread Carl Eugen Hoyos
2019-03-21 0:04 GMT+01:00, Swaraj Hota : > Okay, I found out the metadata block contains fields like: > logo (a url to thumbnail), tags (in Chinese), > title (in Chinese as well), Can you convert the title to something that your terminal (set to utf8) can display? There is "title" metadata, so

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-20 Thread Swaraj Hota
Okay, I found out the metadata block contains fields like: logo (a url to thumbnail), tags (in Chinese), title (in Chinese as well), and other information which mostly seem to be related to streaming. I'm not sure though if anything is much useful. Please do suggest if you think any of these can

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-20 Thread Carl Eugen Hoyos
2019-03-19 18:11 GMT+01:00, swarajhota...@gmail.com : > From: Swaraj Hota > > Fixes ticket #4519. > --- > This is my qualification task for GSoC 2019. > Please suggest any more changes if required. There is a zipped section in the files starting at 0xe4, the password is "meta". Is there

[FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

2019-03-19 Thread swarajhota353
From: Swaraj Hota Fixes ticket #4519. --- This is my qualification task for GSoC 2019. Please suggest any more changes if required. Signed-off-by: Swaraj Hota --- Changelog| 1 + libavformat/allformats.c | 1 + libavformat/flvdec.c | 38