Re: [FFmpeg-devel] [PATCH] avformat/format: silence -Wdiscarded-qualifiers

2015-09-19 Thread Ganesh Ajjanagadde
On Wed, Sep 16, 2015 at 9:08 PM, Michael Niedermayer wrote: > On Wed, Sep 16, 2015 at 06:50:54PM -0400, Ganesh Ajjanagadde wrote: >> lpd.buf is non-const and discards the const qualifier of zerobuffer. >> This fixes -Wdiscarded-qualifiers observed with GCC 5.2. >> >> Signed-off-by: Ganesh Ajjanaga

Re: [FFmpeg-devel] [PATCH] avformat/format: silence -Wdiscarded-qualifiers

2015-09-16 Thread Timothy Gu
On Wed, Sep 16, 2015 at 6:09 PM Michael Niedermayer wrote: > this is wrong, the buffer is constant > if the content of the buffer would change that would be a serious > bug. > Before this change the compiler would detect direct changes done to > the buffer > Commit reverted before a consensus is

Re: [FFmpeg-devel] [PATCH] avformat/format: silence -Wdiscarded-qualifiers

2015-09-16 Thread Michael Niedermayer
On Wed, Sep 16, 2015 at 06:50:54PM -0400, Ganesh Ajjanagadde wrote: > lpd.buf is non-const and discards the const qualifier of zerobuffer. > This fixes -Wdiscarded-qualifiers observed with GCC 5.2. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/format.c | 2 +- > 1 file changed, 1 ins

Re: [FFmpeg-devel] [PATCH] avformat/format: silence -Wdiscarded-qualifiers

2015-09-16 Thread Timothy Gu
On Wed, Sep 16, 2015 at 3:50 PM, Ganesh Ajjanagadde wrote: > lpd.buf is non-const and discards the const qualifier of zerobuffer. > This fixes -Wdiscarded-qualifiers observed with GCC 5.2. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/format.c | 2 +- > 1 file changed, 1 insertion(+)

[FFmpeg-devel] [PATCH] avformat/format: silence -Wdiscarded-qualifiers

2015-09-16 Thread Ganesh Ajjanagadde
lpd.buf is non-const and discards the const qualifier of zerobuffer. This fixes -Wdiscarded-qualifiers observed with GCC 5.2. Signed-off-by: Ganesh Ajjanagadde --- libavformat/format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/format.c b/libavformat/format.c