Re: [FFmpeg-devel] [PATCH] avformat/framehash: print channel layout as a string instead of a hex value

2016-09-28 Thread James Almer
On 9/28/2016 8:26 PM, Michael Niedermayer wrote: > On Wed, Sep 28, 2016 at 08:18:20PM -0300, James Almer wrote: >> On 9/28/2016 8:09 PM, James Almer wrote: >>> On 9/28/2016 7:35 PM, Michael Niedermayer wrote: On Wed, Sep 28, 2016 at 07:23:37PM -0300, James Almer wrote: > Numerical values

Re: [FFmpeg-devel] [PATCH] avformat/framehash: print channel layout as a string instead of a hex value

2016-09-28 Thread Michael Niedermayer
On Wed, Sep 28, 2016 at 08:18:20PM -0300, James Almer wrote: > On 9/28/2016 8:09 PM, James Almer wrote: > > On 9/28/2016 7:35 PM, Michael Niedermayer wrote: > >> On Wed, Sep 28, 2016 at 07:23:37PM -0300, James Almer wrote: > >>> Numerical values for channel layout can be confusing and unintuitive,

Re: [FFmpeg-devel] [PATCH] avformat/framehash: print channel layout as a string instead of a hex value

2016-09-28 Thread James Almer
On 9/28/2016 8:09 PM, James Almer wrote: > On 9/28/2016 7:35 PM, Michael Niedermayer wrote: >> On Wed, Sep 28, 2016 at 07:23:37PM -0300, James Almer wrote: >>> Numerical values for channel layout can be confusing and unintuitive, >>> especially >>> when no channel count is printed. >> >> doesnt

Re: [FFmpeg-devel] [PATCH] avformat/framehash: print channel layout as a string instead of a hex value

2016-09-28 Thread James Almer
On 9/28/2016 7:35 PM, Michael Niedermayer wrote: > On Wed, Sep 28, 2016 at 07:23:37PM -0300, James Almer wrote: >> Numerical values for channel layout can be confusing and unintuitive, >> especially >> when no channel count is printed. > > doesnt this break the format in libavformat/hashenc.c >

Re: [FFmpeg-devel] [PATCH] avformat/framehash: print channel layout as a string instead of a hex value

2016-09-28 Thread Michael Niedermayer
On Wed, Sep 28, 2016 at 07:23:37PM -0300, James Almer wrote: > Numerical values for channel layout can be confusing and unintuitive, > especially > when no channel count is printed. doesnt this break the format in libavformat/hashenc.c for format_version=2 ? [...] -- Michael GnuPG

[FFmpeg-devel] [PATCH] avformat/framehash: print channel layout as a string instead of a hex value

2016-09-28 Thread James Almer
Numerical values for channel layout can be confusing and unintuitive, especially when no channel count is printed. Signed-off-by: James Almer --- libavformat/framehash.c | 5 - tests/ref/fate/8bps | 2 +-