Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Liu Steven
> 在 2019年7月1日,下午4:49,Nicolas George 写道: > > Liu Steven (12019-07-01): >> Just leave the old numeric code to some people like it. I think the >> better to remove it, but i cannot sure if that is useful to other >> people :D. > > Many places only print the error message. I see no difference spec

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Nicolas George
Liu Steven (12019-07-01): > For example: > When i debug the code: it give me message: > > [http @ 0x7ff64540c200] URL read error: -541478725 > after patch: > [http @ 0x7ff64540c200] URL read error: End of file > > I think the message after patch is easier to understand :D I do

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Liu Steven
> 在 2019年7月1日,下午4:49,Nicolas George 写道: > > Liu Steven (12019-07-01): >> Just leave the old numeric code to some people like it. I think the >> better to remove it, but i cannot sure if that is useful to other >> people :D. > > Many places only print the error message. I see no difference spec

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Nicolas George
Liu Steven (12019-07-01): > Just leave the old numeric code to some people like it. I think the > better to remove it, but i cannot sure if that is useful to other > people :D. Many places only print the error message. I see no difference specific to this specific place. Regards, -- Nicolas G

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Liu Steven
> 在 2019年7月1日,下午3:47,Nicolas George 写道: > > Steven Liu (12019-07-01): >> Signed-off-by: Steven Liu >> --- >> libavformat/http.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Any reason to leave the nummeric code at all? Just leave the old numeric code to some people like it. I t

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Nicolas George
Steven Liu (12019-07-01): > Signed-off-by: Steven Liu > --- > libavformat/http.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Any reason to leave the nummeric code at all? Regards, -- Nicolas George signature.asc Description: PGP signature __

[FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 5a937994cf..1ee4d5189c 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1638,7 +1638,7 @@ static int http_shutdown(URLCont