Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread Limin Wang
On Wed, Apr 08, 2020 at 09:34:45AM +0200, pkv wrote: > > Le 08/04/2020 à 3:45 am, Limin Wang a écrit : > >On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > >>Hi > >> > >>Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > >>>On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > Hi > >

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread Jack Waller
On Wed, Apr 8, 2020 at 3:34 PM pkv wrote: > > Le 08/04/2020 à 3:45 am, Limin Wang a écrit : > > On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > >> Hi > >> > >> Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > >>> On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > Hi > >

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread pkv
Le 08/04/2020 à 3:45 am, Limin Wang a écrit : On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: Hi Le 08/04/2020 à 12:33 am, Limin Wang a écrit : On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: Hi new patch for latency option following the comments from N. George. I recall I had su

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread Hendrik Leppkes
On Wed, Apr 8, 2020 at 3:46 AM Limin Wang wrote: > > On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > > Hi > > > > Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > > >On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > > >>Hi > > >> > > >>new patch for latency option following the comment

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Moritz Barsnick
On Wed, Apr 08, 2020 at 09:45:57 +0800, Limin Wang wrote: > On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > > Can you produce code broken by that change ? > > What's your command line? > I recall If use AV_OPT_TYPE_DURATION for option, the default is in unit of > second if your > don't add

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Limin Wang
On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > Hi > > Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > >On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > >>Hi > >> > >>new patch for latency option following the comments from N. George. > >I recall I had submit a patchset for related o

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread pkv
Hi Le 08/04/2020 à 12:33 am, Limin Wang a écrit : On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: Hi new patch for latency option following the comments from N. George. I recall I had submit a patchset for related option incliding latency. https://patchwork.ffmpeg.org/project/ffmpeg/patc

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Limin Wang
On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > Hi > > new patch for latency option following the comments from N. George. I recall I had submit a patchset for related option incliding latency. https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200331140808.8839-2-lance.lmw...@gmail.com/

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Nicolas George
pkv (12020-04-07): > new patch for latency option following the comments from N. George. Thanks. > > = > > Updated protocol doc for srt to specify the unit of various latency options. > Furthermore the type of the latency options is changed to > AV_OPT_TYPE_DURATION > (following comment fro

[FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread pkv
Hi new patch for latency option following the comments from N. George. = Updated protocol doc for srt to specify the unit of various latency options. Furthermore the type of the latency options is changed to AV_OPT_TYPE_DURATION (following comment from N. George). The microsecond unit ha