Re: [FFmpeg-devel] [PATCH] avformat/libssh: add AVOptions for authentication

2020-07-14 Thread Nicolas Frattaroli
Actually, forget this patch. It was modeled after the previous AVOption patch I sent for the ftp protocol, but a better more generic approach would be to have some sort of callback for API users so they can just implement .netrc. Like this, with just AVOption for usernames and passwords, we can't

Re: [FFmpeg-devel] [PATCH] avformat/libssh: add AVOptions for authentication

2020-07-14 Thread Nicolas George
James Almer (12020-07-14): > Perhaps this should instead be implemented as an AV_OPT_TYPE_DICT option > that can accept anything you would otherwise pass as part of the url, so > user, pass, port, etc. It makes things more complicated for us (accessing a dictionary instead of options directly), fo

Re: [FFmpeg-devel] [PATCH] avformat/libssh: add AVOptions for authentication

2020-07-14 Thread James Almer
On 7/14/2020 3:06 PM, Nicolas Frattaroli wrote: > This introduces two new AVOption options for the SFTP protocol, > one named sftp_user to supply the username to be used for auth, > one named sftp_password to supply the password to be used for auth. > > These are useful for when an API user does n

Re: [FFmpeg-devel] [PATCH] avformat/libssh: add AVOptions for authentication

2020-07-14 Thread Nicolas George
Thanks for the patch. I thnink it is a good idea. See preliminary comments below. I do not know if Lukasz, who wrote this file, still reads the list. If he does not appear in the next few days, try Ccing him. Nicolas Frattaroli (12020-07-14): > This introduces two new AVOption options for the SF

[FFmpeg-devel] [PATCH] avformat/libssh: add AVOptions for authentication

2020-07-14 Thread Nicolas Frattaroli
This introduces two new AVOption options for the SFTP protocol, one named sftp_user to supply the username to be used for auth, one named sftp_password to supply the password to be used for auth. These are useful for when an API user does not wish to deal with URL manipulation and percent encoding