Re: [FFmpeg-devel] [PATCH] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-12 Thread Derek Buitenhuis
On 12/03/2021 11:20, Martin Storsjö wrote: > LGTM, I guess the only question that remains is whether "dash" in the > compatible brands can imply the same too. (Our own muxer never sets "dash" > as the major brand, only as a compatible brand, and that only if we only > produce one global sidx.)

Re: [FFmpeg-devel] [PATCH] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-12 Thread Martin Storsjö
On Wed, 10 Mar 2021, Derek Buitenhuis wrote: Files with the "dash" major brand are guaranteed to only have a single initialization range for the whole file. We can check this and stop appropriately - which is useful, as the existing check to see if the offset reaches the end of the file is not

[FFmpeg-devel] [PATCH] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-10 Thread Derek Buitenhuis
Files with the "dash" major brand are guaranteed to only have a single initialization range for the whole file. We can check this and stop appropriately - which is useful, as the existing check to see if the offset reaches the end of the file is not sufficient. For example, YouTube creates valid