On Mon, Apr 13, 2020 at 2:01 PM Michael Bradshaw wrote:
> Sorry about that. I should have been more thorough. Attached patch fixes
> fate.
>
And another that got missed.
0001-tests-ref-vsynth-fix-fate-colr-changes-again.patch
Description: Binary data
___
On Mon, Apr 13, 2020 at 1:24 PM Andriy Gelman
wrote:
> seems to break fate
> make fate-vsynth1-dnxhd-1080i-colr
Sorry about that. I should have been more thorough. Attached patch fixes
fate.
0001-tests-ref-vsynth-fix-fate-colr-changes.patch
Description: Binary data
___
On Mon, 13. Apr 10:29, Michael Bradshaw wrote:
> On Tue, Mar 31, 2020 at 6:23 AM Derek Buitenhuis
> wrote:
>
> > I agree strongly with Michael's points.
>
>
> I've pushed the patch to master.
seems to break fate
make fate-vsynth1-dnxhd-1080i-colr
TESTvsynth1-dnxhd-1080i-colr
--- ./tests/
On Tue, Mar 31, 2020 at 6:23 AM Derek Buitenhuis
wrote:
> I agree strongly with Michael's points.
I've pushed the patch to master.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
On 31/03/2020 00:25, Michael Bradshaw wrote:
> If this really breaks things for people (which I highly doubt it will) they
> can always send a patch with a better and more robust implementation. But I
> feel strongly that we should not stabilize the write_colr flag with this
> auto-guessing logic.
On Mon, Mar 30, 2020 at 4:48 PM Carl Eugen Hoyos wrote:
> I believe there is some historical evidence that this guessing is needed
> to get visually correct output in many cases.
I haven't found any evidence of that. This guessing has been part of the
code since the write_colr flag was original
Am Di., 31. März 2020 um 00:33 Uhr schrieb Michael Bradshaw
:
>
> On Mon, Mar 30, 2020 at 4:23 PM Carl Eugen Hoyos wrote:
>
> > But not every call of the mov muxer is done for Dolby Vision
> > samples or do I misunderstand?
>
> You're right that most muxing doesn't involve Dolby Vision. However, e
On Mon, Mar 30, 2020 at 4:23 PM Carl Eugen Hoyos wrote:
> But not every call of the mov muxer is done for Dolby Vision
> samples or do I misunderstand?
You're right that most muxing doesn't involve Dolby Vision. However, even
for cases that don't involve Dolby Vision I still think guessing is t
Am Mo., 30. März 2020 um 22:28 Uhr schrieb Michael Bradshaw
:
>
> See [1]. Apple requests that colr atom values be 2 ("unspecified") for
> Dolby Vision.
> // e.g., Dolby Vision for Apple devices should be set to
> AVCOL_PRI_UNSPECIFIED.
But not every call of the mov muxer is done for Dolby Visio
See [1]. Apple requests that colr atom values be 2 ("unspecified") for
Dolby Vision.
Please review.
--Michael
[1]:
https://developer.apple.com/av-foundation/High-Dynamic-Range-Metadata-for-Apple-Devices.pdf
0001-avformat-movenc-stop-guessing-colr-atom-values.patch
Description: Binary data
_
10 matches
Mail list logo
