Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

On Tue, 1 Dec 2015 10:54:38 -0800 chcunning...@chromium.org wrote: > From: Chris Cunningham > > "Fast seek" uses linear interpolation to find the position of the > requested seek time. For CBR this is more direct than using the > mp3 TOC and bypassing the TOC avoids problems with TOC precision.

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

On Wed, 2 Dec 2015 02:23:15 +0100 Michael Niedermayer wrote: > On Tue, Dec 01, 2015 at 10:47:53AM -0800, Chris Cunningham wrote: > > Thanks wm4, next patch will fix that declaration. > > > > Michael, any concerns? > > iam fine with the patch > > > > > > On Mon, Nov 30, 2015 at 2:51 PM, wm4

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

On Tue, Dec 01, 2015 at 10:47:53AM -0800, Chris Cunningham wrote: > Thanks wm4, next patch will fix that declaration. > > Michael, any concerns? iam fine with the patch > > On Mon, Nov 30, 2015 at 2:51 PM, wm4 wrote: [...] > > Other than that LGTM. wm4, your replies are missing from the maili

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

From: Chris Cunningham "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems with TOC precision. (see https://crbug.com/545914#c13) For VBR, fast seek is not precise, so cont

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

Thanks wm4, next patch will fix that declaration. Michael, any concerns? On Mon, Nov 30, 2015 at 2:51 PM, wm4 wrote: > On Mon, 30 Nov 2015 14:29:50 -0800 > chcunning...@chromium.org wrote: > > > From: Chris Cunningham > > > > "Fast seek" uses linear interpolation to find the position of the >

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

From: Chris Cunningham "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems with TOC precision. (see https://crbug.com/545914#c13) For VBR, fast seek is not precise, so cont

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

Looks like I messed up the tab for "return best_pos;"... fix incoming. On Mon, Nov 30, 2015 at 2:10 PM, wrote: > From: Chris Cunningham > > "Fast seek" uses linear interpolation to find the position of the > requested seek time. For CBR this is more direct than using the > mp3 TOC and bypassing

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

From: Chris Cunningham "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems with TOC precision. (see https://crbug.com/545914#c13) For VBR, fast seek is not precise, so cont

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

(Fixed CCs) Thanks for review. Patch coming shortly. On Thu, Nov 26, 2015 at 10:13 AM, wm4 wrote: > On Tue, 24 Nov 2015 16:55:03 -0800 > chcunning...@chromium.org wrote: > > > From: Chris Cunningham > > > > "Fast seek" uses linear interpolation to find the position of the > > requested seek ti

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

The new patch incorporates the "3 use-cases" feedback from wm4. 1. default: use generic (accurate but slow) seeking 2. fast: set -fflags fastseek to get fast accurate scaled seek for CBR, TOC seek for VBR falling back to scaling if no TOC exists 3. custom: set -usetoc 1 to always use TOC for VBR &

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

From: Chris Cunningham "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems with TOC precision. (see https://crbug.com/545914#c13) For VBR, fast seek is not precise, so cont

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

Adding everyone back on the cc list for a convo with wm4 (meant for everyone). Expect a new patch shortly to go with this discussion. Also, just a note for posterity and to make sure I haven't missed anything: It seems the mp3 TOC is really not a precise tool for seeking, particularly in large fil

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

On Mon, Nov 16, 2015 at 05:28:58PM -0800, Chris Cunningham wrote: > To test this new patch, again use testcount.mp3 > (CBR, > corrupt TOC). > > Current ffmpeg (with none of my mp3 patches) > > ./ffplay testcount.mp3 -ss 00:33:20 -use

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

To test this new patch, again use testcount.mp3 (CBR, corrupt TOC). Current ffmpeg (with none of my mp3 patches) ./ffplay testcount.mp3 -ss 00:33:20 -usetoc 0 plays out "1395", which is correct ./ffplay testcount.mp3 -ss 00:33:20

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

From: Chris Cunningham "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems when the TOC is corrupted (e.g. https://crbug.com/545914). For VBR, fast seek is not precise, so

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

Hey, sorry for the slow reply. Use this sample file. Its a CBR file with a corrupt TOC. http://happyworm.com/jPlayerLab/halite/jumptest/testcount.mp3 Before applying my patch: ./ffplay -ss 00:33:20 testcount.mp3 -usetoc 0 plays out "1395", which is the correct audio for the given seek time ./f

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

On Wed, Nov 04, 2015 at 05:21:57PM -0800, Chris Cunningham wrote: > "Fast seek" uses linear interpolation to find the position of the > requested seek time. For CBR this is more direct than using the > mp3 TOC and bypassing the TOC avoids problems when the TOC is > corrupted (e.g. https://crbug.com

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

"Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems when the TOC is corrupted (e.g. https://crbug.com/545914). For VBR, fast seek is not precise, so continue to prefer the TO