Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Maksym Veremeyenko
On 08.11.2021 17:31, Kieran Kunhya wrote: [...] The positioning of the packet relative to the PCR matters. Also splice_time() is relative to the new PCR and timestamps which I don't think the mux here can guarantee? i could be wrong, but time_signal() carry splice_time() what carry pts_time

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Kieran Kunhya
On Mon, 8 Nov 2021 at 15:17, Maksym Veremeyenko wrote: > On 08.11.2021 16:41, Kieran Kunhya wrote: > > On Mon, 8 Nov 2021 at 06:35, Maksym Veremeyenko > wrote: > > > >> Hi, > >> > >> Attached patch implement muxing SCTE-35 and EPG packets into mpegts > stream. > >> > > > > SCTE Markers need

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Maksym Veremeyenko
On 08.11.2021 16:41, Kieran Kunhya wrote: On Mon, 8 Nov 2021 at 06:35, Maksym Veremeyenko wrote: Hi, Attached patch implement muxing SCTE-35 and EPG packets into mpegts stream. SCTE Markers need timestamping, no? SCTE markers has no timestamping, during reading at mpegts.c it

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Kieran Kunhya
On Mon, 8 Nov 2021 at 06:35, Maksym Veremeyenko wrote: > Hi, > > Attached patch implement muxing SCTE-35 and EPG packets into mpegts stream. > SCTE Markers need timestamping, no? Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-07 Thread Maksym Veremeyenko
Hi, Attached patch implement muxing SCTE-35 and EPG packets into mpegts stream. -- Maksym Veremeyenko From dc1b87f5e34c688bb3691767f8026a2815aab03e Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko Date: Mon, 8 Nov 2021 08:10:59 +0200 Subject: [PATCH] avformat/mpegtsenc: Implement muxing