Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-09 Thread Tomas Härdin
sön 2021-11-07 klockan 12:32 +0100 skrev Marton Balint: > > > + > > +    while (channel_ordering_ptr->uid[0]) { > > +    if (IS_KLV_KEY(channel_ordering_ptr->uid, > > mca_sub_descriptor->mca_label_dictionary_id)) { > > You should check if current_channel < desc

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-07 Thread Marton Balint
On Fri, 5 Nov 2021, Marc-Antoine Arnaud wrote: --- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 280 ++- 2 files changed, 275 insertions(+), 6 deletions(-) Could you mention in the commit description which standards/recommendations cover MCA i

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-05 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 280 ++- 2 files changed, 275 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-05 Thread Tomas Härdin
> +    if(channel_ordering_ptr->service_type != > AV_AUDIO_SERVICE_TYPE_NB) { > +    ast = (enum > AVAudioServiceType*)av_stream_new_side_data(st, > AV_PKT_DATA_AUDIO_SERVICE_TYPE, sizeof(*ast)); ast == NULL still needs handling here I don't see

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-05 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 277 ++- 2 files changed, 272 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-05 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 280 ++- 2 files changed, 275 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-11-02 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 280 ++- 2 files changed, 275 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-28 Thread Tomas Härdin
ons 2021-10-27 klockan 15:50 +0200 skrev Marc-Antoine Arnaud: > +if(channel_ordering_ptr->service_type != > AV_AUDIO_SERVICE_TYPE_NB) { > +ast = (enum > AVAudioServiceType*)av_stream_new_side_data(st, > AV_PKT_DATA_AUDIO_SERVICE_TYPE, siz

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-27 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 282 ++- 2 files changed, 277 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-20 Thread Tomas Härdin
mån 2021-10-18 klockan 17:06 +0200 skrev Marc-Antoine Arnaud: > > +static int mxf_audio_remapping(int* channel_ordering, uint8_t* data, > int size, int sample_size, int channels) > +{ > +    int sample_offset = channels * sample_size; > +    int number_of_samples = size / sample_offset; > +    uin

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-18 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 283 ++- 2 files changed, 278 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-12 Thread Pierre-Anthony Lemieux
On Tue, Oct 12, 2021 at 12:29 PM Marton Balint wrote: > > > > On Tue, 12 Oct 2021, Tomas Härdin wrote: > > > mån 2021-10-11 klockan 18:32 +0200 skrev Marc-Antoine Arnaud: > >> --- > >> libavformat/mxf.h| 1 + > >> libavformat/mxfdec.c | 276 > >> ++- >

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-12 Thread Marton Balint
On Tue, 12 Oct 2021, Tomas Härdin wrote: mån 2021-10-11 klockan 18:32 +0200 skrev Marc-Antoine Arnaud: ---  libavformat/mxf.h    |   1 +  libavformat/mxfdec.c | 276 ++-  2 files changed, 271 insertions(+), 6 deletions(-) Did we reach a consensus on th

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-12 Thread Tomas Härdin
mån 2021-10-11 klockan 18:32 +0200 skrev Marc-Antoine Arnaud: > --- >  libavformat/mxf.h    |   1 + >  libavformat/mxfdec.c | 276 > ++- >  2 files changed, 271 insertions(+), 6 deletions(-) Did we reach a consensus on this? While I think signalling ffmpeg to

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-11 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 276 ++- 2 files changed, 271 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-08-18 Thread Tomas Härdin
tor 2021-08-12 klockan 14:38 +0200 skrev Marc-Antoine Arnaud: @@ -177,6 +179,7 @@ typedef struct { int body_sid; MXFWrappingScheme wrapping; int edit_units_per_packet; /* how many edit units to read at a time (PCM, ClipWrapped) */ +    int* channel_ordering; Is there a maximum numb

[FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-08-12 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 356 ++- 2 files changed, 351 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5