On 3/26/2018 3:27 PM, Gyan Doshi wrote:
> On 3/24/2018 7:39 AM, Michael Niedermayer wrote:
>> On Thu, Mar 22, 2018 at 11:04:21PM +0530, Gyan Doshi wrote:
>
>>>
>>> Fixes #7091
>>> ---
>>> libavformat/segafilm.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> should be ok
>
>
On 3/24/2018 7:39 AM, Michael Niedermayer wrote:
On Thu, Mar 22, 2018 at 11:04:21PM +0530, Gyan Doshi wrote:
Fixes #7091
---
libavformat/segafilm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
should be ok
Ping for push. There's a pending patch by another user blocked by
On Thu, Mar 22, 2018 at 11:04:21PM +0530, Gyan Doshi wrote:
> Set the packet flag using constant as well.
> segafilm.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> d9d4db403c46a179ea93aab0d85904e7b4a831d2
> 0001-avformat-segafilm-fix-keyframe-detection-and-set-pac.patch
>
Set the packet flag using constant as well.
From 905cc5f1146c957ae4290b44a06a22a7524a87de Mon Sep 17 00:00:00 2001
From: Gyan Doshi
Date: Wed, 21 Mar 2018 18:59:33 +0530
Subject: [PATCH] avformat/segafilm - fix keyframe detection and set packet
flags
Streams from a
On 3/22/2018 2:02 AM, Carl Eugen Hoyos wrote:
Can you comment on why this 15-year old code was wrong?
It inverts the correct assignment of keyframe status. On the sample file
uploaded to trac, the existing code marks the first frame as non-KF and
all remaining frames as KF.
Changed to
On Wed, Mar 21, 2018 at 1:32 PM, Carl Eugen Hoyos wrote:
> 2018-03-21 14:37 GMT+01:00, Gyan Doshi :
> Can you comment on why this 15-year old code was wrong?
I think it was de facto unused before now. Since it wasn't passed
through to AVPacket it wasn't
2018-03-21 21:32 GMT+01:00, Carl Eugen Hoyos :
> 2018-03-21 14:37 GMT+01:00, Gyan Doshi :
>> Fix for ticket 7091.
>
>> -film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 0 :
>> 1;
>> +film->sample_table[i].keyframe = (scratch[8]
2018-03-21 14:37 GMT+01:00, Gyan Doshi :
> Fix for ticket 7091.
> -film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 0 : 1;
> +film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 1 : 0;
Can you comment on why this 15-year old code was wrong?
Fix for ticket 7091.
Regards,
Gyan
From 24a68eca54a5051b3386664f07d21358aa0db02d Mon Sep 17 00:00:00 2001
From: Gyan Doshi
Date: Wed, 21 Mar 2018 18:59:33 +0530
Subject: [PATCH] avformat/segafilm - fix keyframe detection and set packet
flags
Streams from a Segafilm cpk