Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-09 Thread Gilles Chanteperdrix
On Sun, Mar 08, 2015 at 10:57:54AM +0100, Nicolas George wrote: L'octidi 18 ventôse, an CCXXIII, Clement Boesch a écrit : Try adding tags with no text maybe. You may also try ASS drawing mode, but FFmpeg probably doesn't do cray stuff about it. I tried various combinations, including empty

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-08 Thread Nicolas George
L'octidi 18 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : If I read ffmpeg current documentation here: http://www.ffmpeg.org/doxygen/2.5/group__lavc__core.html#ga828218dcb8874ab2c5af8d486c365421 It seems that when a subtitle rect type is SUBTITLE_ASS (which is the case in the code

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-08 Thread Nicolas George
L'octidi 18 ventôse, an CCXXIII, Clement Boesch a écrit : Try adding tags with no text maybe. You may also try ASS drawing mode, but FFmpeg probably doesn't do cray stuff about it. I tried various combinations, including empty styles, drawing mode, Picture, Comment, empty lines, missing comma,

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Clément Bœsch
On Sun, Mar 08, 2015 at 12:27:49AM +0100, Gilles Chanteperdrix wrote: On Sat, Mar 07, 2015 at 11:46:44PM +0100, Nicolas George wrote: Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : You need an ASS file that produces a sub-title frame without text. I have been carrying

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Nicolas George
Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : When transcoding to SRT, do not assume that each sub-title frame contains text. Can you explain how to reproduce the segfault? I tried transcoding an ASS file and it worked. Regards, -- Nicolas George signature.asc

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Gilles Chanteperdrix
On Sat, Mar 07, 2015 at 11:46:44PM +0100, Nicolas George wrote: Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : You need an ASS file that produces a sub-title frame without text. I have been carrying this patch since 2013, I am afraid I no longer have the problematic file.

[FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Gilles Chanteperdrix
When transcoding to SRT, do not assume that each sub-title frame contains text. Signed-off-by: Gilles Chanteperdrix gilles.chanteperd...@xenomai.org --- libavcodec/srtenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/srtenc.c b/libavcodec/srtenc.c index 3287970..ab790f8

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Gilles Chanteperdrix
On Sat, Mar 07, 2015 at 11:46:44PM +0100, Nicolas George wrote: Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : You need an ASS file that produces a sub-title frame without text. I have been carrying this patch since 2013, I am afraid I no longer have the problematic file.

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Gilles Chanteperdrix
On Sat, Mar 07, 2015 at 09:18:41PM +0100, Nicolas George wrote: Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : When transcoding to SRT, do not assume that each sub-title frame contains text. Can you explain how to reproduce the segfault? I tried transcoding an ASS file

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Nicolas George
Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : You need an ASS file that produces a sub-title frame without text. I have been carrying this patch since 2013, I am afraid I no longer have the problematic file. I tried an ASS file with an empty text part, and it did not crash