Re: [FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Nicolas George
Andreas Rheinhardt (12020-09-20): > parse_string() checks for this (for the content, not the labels, where > the check is unnecessary). Oh, even better. Then ok without reservation. -- Nicolas George signature.asc Description: PGP signature ___ ff

Re: [FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-09-20): >> The tedcaptions demuxer uses an AVBPrint whose string is not restricted >> to its internal buffer; it therefore needs to be cleaned up, yet this is >> not done on error, as parse_file() returned simply returned directly. >> This is fixed by goi

Re: [FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Nicolas George
Andreas Rheinhardt (12020-09-20): > The tedcaptions demuxer uses an AVBPrint whose string is not restricted > to its internal buffer; it therefore needs to be cleaned up, yet this is > not done on error, as parse_file() returned simply returned directly. > This is fixed by going to fail first in su

[FFmpeg-devel] [PATCH] avformat/tedcaptionsdec: Fix leak of AVBPrint upon error

2020-09-20 Thread Andreas Rheinhardt
The tedcaptions demuxer uses an AVBPrint whose string is not restricted to its internal buffer; it therefore needs to be cleaned up, yet this is not done on error, as parse_file() returned simply returned directly. This is fixed by going to fail first in such cases. Furthermore, there is also a sec