Re: [FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread Michael Niedermayer
On Tue, May 17, 2016 at 11:28:32AM -0700, chcunning...@chromium.org wrote: > From: Chris Cunningham > > Fixes: undefined shift. > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1336

Re: [FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread Chris Cunningham
New patch drops the U. Hendrik, you'r right about the negative, but you're also right about the 0. 0 is a case of undefined shift behavior (shift becomes -1). On Tue, May 17, 2016 at 11:28 AM, wrote: > From: Chris Cunningham > > Fixes: undefined shift. > --- > libavformat/utils.c | 2 +- > 1 f

[FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread chcunningham
From: Chris Cunningham Fixes: undefined shift. --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 5f5f03e..d1e4306 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2955,7 +2955,7 @@ enum AVCode

Re: [FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-17 Thread Hendrik Leppkes
On Tue, May 17, 2016 at 3:21 AM, Michael Niedermayer wrote: > On Mon, May 16, 2016 at 03:21:43PM -0700, chcunning...@chromium.org wrote: >> From: Chris Cunningham >> >> Fixes: undefined shift. >> --- >> libavformat/utils.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-16 Thread Michael Niedermayer
On Mon, May 16, 2016 at 03:21:43PM -0700, chcunning...@chromium.org wrote: > From: Chris Cunningham > > Fixes: undefined shift. > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 5f5f03e..ad5cfa2

[FFmpeg-devel] [PATCH] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

2016-05-16 Thread chcunningham
From: Chris Cunningham Fixes: undefined shift. --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 5f5f03e..ad5cfa2 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2955,7 +2955,7 @@ enum AVCode