Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-25 Thread Rainer Hochecker
wm4 googlemail.com> writes: > > > Now we get multiple packets with equal pts. This requires an additional > > change for us. > > http://paste.ubuntu.com/8426767/ > > Why? I don't think subtitle packets with same PTS were impossible > before. Good question. I wish the author of this code was ar

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-25 Thread wm4
On Thu, 25 Sep 2014 18:18:45 + (UTC) Rainer Hochecker wrote: > Clément Bœsch pkh.me> writes: > > > > > I'm seeing timestamps set in the packets with: > > ffprobe -show_packets -show_data -select_streams s:0 > ~/samples/Test_File-01.mkv > > > > Same with other streams > > > > > Thanks

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-25 Thread Rainer Hochecker
Clément Bœsch pkh.me> writes: > > I'm seeing timestamps set in the packets with: > ffprobe -show_packets -show_data -select_streams s:0 ~/samples/Test_File-01.mkv > > Same with other streams > Thanks, making use of ffprobe was a good idea. Now I see the difference. With version < 2.4 we go

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-25 Thread Clément Bœsch
On Thu, Sep 25, 2014 at 12:41:50PM +, Rainer Hochecker wrote: > Rainer Hochecker online.de> writes: > > > > > It's me again. I got a matroshka sample for which I get ASS subs without > > timestamps (NOPTS_VALUE): > > https://mega.co.nz/#!dEcRwZ4C!cg_6xlpPlhRN0trGEDH1C-ErJ7gXIe6CUezaEokBSV8

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-25 Thread Rainer Hochecker
Rainer Hochecker online.de> writes: > > It's me again. I got a matroshka sample for which I get ASS subs without > timestamps (NOPTS_VALUE): > https://mega.co.nz/#!dEcRwZ4C!cg_6xlpPlhRN0trGEDH1C-ErJ7gXIe6CUezaEokBSV8 . > > Am I doing anything wrong? > > Rainer > This file has no timestamps

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-25 Thread Rainer Hochecker
Clément Bœsch pkh.me> writes: > > Supporting that properly is not that much work; there will just be a > somewhat nasty convert from this layout to the internal one (when that > last one will be sane). > > Maybe that's rare indeed, but then someone will suddenly find a .nut, or > maybe try to p

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Clément Bœsch
On Mon, Sep 22, 2014 at 09:13:18PM +0200, wm4 wrote: > On Mon, 22 Sep 2014 21:05:19 +0200 > Clément Bœsch wrote: > > > On Mon, Sep 22, 2014 at 06:55:54PM +, Rainer Hochecker wrote: > > > Clément Bœsch pkh.me> writes: > > > > > > > > > > > On Mon, Sep 22, 2014 at 03:12:02PM +, Rainer Ho

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread wm4
On Mon, 22 Sep 2014 21:05:19 +0200 Clément Bœsch wrote: > On Mon, Sep 22, 2014 at 06:55:54PM +, Rainer Hochecker wrote: > > Clément Bœsch pkh.me> writes: > > > > > > > > On Mon, Sep 22, 2014 at 03:12:02PM +, Rainer Hochecker wrote: > > > [...] > > > > Hi, > > > > > > > > Thank you ver

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Clément Bœsch
On Mon, Sep 22, 2014 at 06:55:54PM +, Rainer Hochecker wrote: > Clément Bœsch pkh.me> writes: > > > > > On Mon, Sep 22, 2014 at 03:12:02PM +, Rainer Hochecker wrote: > > [...] > > > Hi, > > > > > > Thank you very much for this explanation and sorry for not having read > > > release note

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Rainer Hochecker
Clément Bœsch pkh.me> writes: > > On Mon, Sep 22, 2014 at 03:12:02PM +, Rainer Hochecker wrote: > [...] > > Hi, > > > > Thank you very much for this explanation and sorry for not having read > > release notes properly. subs are not my territory but the maintainer is busy > > with real life

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Clément Bœsch
On Mon, Sep 22, 2014 at 03:12:02PM +, Rainer Hochecker wrote: [...] > Hi, > > Thank you very much for this explanation and sorry for not having read > release notes properly. subs are not my territory but the maintainer is busy > with real life so I will try to adapt to those changes. > Feel

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Rainer Hochecker
Clément Bœsch pkh.me> writes: > Hi, > > We just made the ASS packets from the Matroska output them verbatim, and > not hacked with timestamps included into the timestamps. > > The packets are now typically broadcastable to libass. > > Note that this change has been documented since 2.0; doc/API

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Clément Bœsch
On Mon, Sep 22, 2014 at 02:53:12PM +, Rainer Hochecker wrote: > Clément Bœsch pkh.me> writes: > > > > > > > > +1 > > > > Applied > > > > > We at XBMC got the first complaints about broken subtitles. Why was this > removed? Hi, We just made the ASS packets from the Matroska output them

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Clément Bœsch
On Mon, Sep 22, 2014 at 05:04:23PM +0200, Clément Bœsch wrote: > On Mon, Sep 22, 2014 at 02:53:12PM +, Rainer Hochecker wrote: > > Clément Bœsch pkh.me> writes: > > > > > > > > > > > > +1 > > > > > > Applied > > > > > > > > > We at XBMC got the first complaints about broken subtitles. W

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread wm4
On Mon, 22 Sep 2014 14:53:12 + (UTC) Rainer Hochecker wrote: > Clément Bœsch pkh.me> writes: > > > > > > > > +1 > > > > Applied > > > > > We at XBMC got the first complaints about broken subtitles. Why was this > removed? It never worked right in the first place, at least not 100%.

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-22 Thread Rainer Hochecker
Clément Bœsch pkh.me> writes: > > > > +1 > > Applied > We at XBMC got the first complaints about broken subtitles. Why was this removed? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-09 Thread Clément Bœsch
On Sun, Sep 07, 2014 at 10:18:50PM +0200, wm4 wrote: > On Sun, 7 Sep 2014 22:03:26 +0200 > Clément Bœsch wrote: > > > --- > > libavformat/matroska.c| 6 > > libavformat/matroskadec.c | 80 > > --- > > libavformat/matroskaenc.c | 79 > > ---

Re: [FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-07 Thread wm4
On Sun, 7 Sep 2014 22:03:26 +0200 Clément Bœsch wrote: > --- > libavformat/matroska.c| 6 > libavformat/matroskadec.c | 80 > --- > libavformat/matroskaenc.c | 79 -- > libavformat/version.h |

[FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

2014-09-07 Thread Clément Bœsch
--- libavformat/matroska.c| 6 libavformat/matroskadec.c | 80 --- libavformat/matroskaenc.c | 79 -- libavformat/version.h | 3 -- 4 files changed, 168 deletions(-) diff --git a/libavformat/mat