Re: [FFmpeg-devel] [PATCH] avutil/avstring: Inline some tiny functions

2015-09-26 Thread Henrik Gramner
On Sat, Sep 26, 2015 at 7:23 PM, Ganesh Ajjanagadde wrote: > On Sat, Sep 26, 2015 at 1:18 PM, Hendrik Leppkes wrote: >> On Sat, Sep 26, 2015 at 6:48 PM, Ganesh Ajjanagadde wrote: >>> Commit 06eb4f0885746b7e8a652d7b6026abf834e04b73 has a fairly detailed >>> explanation of av_always_inline. Essen

Re: [FFmpeg-devel] [PATCH] avutil/avstring: Inline some tiny functions

2015-09-26 Thread Ganesh Ajjanagadde
On Sat, Sep 26, 2015 at 1:18 PM, Hendrik Leppkes wrote: > On Sat, Sep 26, 2015 at 6:48 PM, Ganesh Ajjanagadde wrote: >> On Sat, Sep 26, 2015 at 12:26 PM, Henrik Gramner wrote: >>> On Sat, Sep 26, 2015 at 6:10 PM, Ganesh Ajjanagadde >>> wrote: Have you compared with av_always_inline? >>> >

Re: [FFmpeg-devel] [PATCH] avutil/avstring: Inline some tiny functions

2015-09-26 Thread Hendrik Leppkes
On Sat, Sep 26, 2015 at 6:48 PM, Ganesh Ajjanagadde wrote: > On Sat, Sep 26, 2015 at 12:26 PM, Henrik Gramner wrote: >> On Sat, Sep 26, 2015 at 6:10 PM, Ganesh Ajjanagadde wrote: >>> Have you compared with av_always_inline? >> >> No, other functions in that header used "inline", so I went with t

Re: [FFmpeg-devel] [PATCH] avutil/avstring: Inline some tiny functions

2015-09-26 Thread Ganesh Ajjanagadde
On Sat, Sep 26, 2015 at 12:26 PM, Henrik Gramner wrote: > On Sat, Sep 26, 2015 at 6:10 PM, Ganesh Ajjanagadde wrote: >> Have you compared with av_always_inline? > > No, other functions in that header used "inline", so I went with the > same for consistency. But I guess we could change those as we

Re: [FFmpeg-devel] [PATCH] avutil/avstring: Inline some tiny functions

2015-09-26 Thread Henrik Gramner
On Sat, Sep 26, 2015 at 6:10 PM, Ganesh Ajjanagadde wrote: > Have you compared with av_always_inline? No, other functions in that header used "inline", so I went with the same for consistency. But I guess we could change those as well if av_always_inline is preferable. ___

Re: [FFmpeg-devel] [PATCH] avutil/avstring: Inline some tiny functions

2015-09-26 Thread Ganesh Ajjanagadde
On Sat, Sep 26, 2015 at 12:04 PM, Henrik Gramner wrote: > They're short enough that inlining them actually reduces code size due to > all the overhead associated with making a function call. > --- > libavutil/avstring.c | 22 -- > libavutil/avstring.h | 22 ++--

[FFmpeg-devel] [PATCH] avutil/avstring: Inline some tiny functions

2015-09-26 Thread Henrik Gramner
They're short enough that inlining them actually reduces code size due to all the overhead associated with making a function call. --- libavutil/avstring.c | 22 -- libavutil/avstring.h | 22 ++ 2 files changed, 18 insertions(+), 26 deletions(-) diff --git