On 7/4/2022 1:55 PM, Michael Niedermayer wrote:
On Sun, Jul 03, 2022 at 09:27:31PM -0300, James Almer wrote:
On 7/3/2022 7:00 AM, Nicolas George wrote:
Andreas Rheinhardt (12022-07-03):
if (!av_bprint_is_complete(bp))
-return AVERROR(ENOMEM);
+
On Sun, Jul 03, 2022 at 09:27:31PM -0300, James Almer wrote:
> On 7/3/2022 7:00 AM, Nicolas George wrote:
> > Andreas Rheinhardt (12022-07-03):
> > > > if (!av_bprint_is_complete(bp))
> > > > -return AVERROR(ENOMEM);
> > > > +break;
> >
> > > Isn't thi
On 7/3/2022 7:00 AM, Nicolas George wrote:
Andreas Rheinhardt (12022-07-03):
if (!av_bprint_is_complete(bp))
-return AVERROR(ENOMEM);
+break;
Isn't this actually still against the API? av_channel_layout_describe()
will not return the correct nu
Andreas Rheinhardt (12022-07-03):
> > if (!av_bprint_is_complete(bp))
> > -return AVERROR(ENOMEM);
> > +break;
> >
> Isn't this actually still against the API? av_channel_layout_describe()
> will not return the correct number of bytes necessary to wri
James Almer:
> The doxy for av_channel_layout_describe() states that the user should look
> at the return value to check if the string was truncated. Returning an error
> code in this scenario goes against this and is an API break.
>
> This is a better fix than the one committed in 8154cb7c2f for
The doxy for av_channel_layout_describe() states that the user should look
at the return value to check if the string was truncated. Returning an error
code in this scenario goes against this and is an API break.
This is a better fix than the one committed in 8154cb7c2f for the timeout
fuzzing iss