Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-03 Thread Michael Niedermayer
On Fri, Oct 02, 2015 at 08:58:10AM +0200, Christophe Gisquet wrote: > 2015-09-28 18:51 GMT+02:00 Christophe Gisquet : > [SNIP] > > Could someone also apply the cosmetic patch for reindentation? applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Christophe Gisquet
2015-09-28 18:51 GMT+02:00 Christophe Gisquet : [SNIP] Could someone also apply the cosmetic patch for reindentation? Thanks, Christophe ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Michael Niedermayer
On Thu, Oct 01, 2015 at 09:54:49PM +0200, Christophe Gisquet wrote: > Hi, > > 2015-10-01 21:35 GMT+02:00 Michael Niedermayer : > > ffmpeg/libavcodec/arm/blockdsp_arm.h:24:6: note: previous declaration of > > ‘ff_blockdsp_init_neon’ was here > > Missed that header... I can only find those using g

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Christophe Gisquet
Hi, 2015-10-01 21:35 GMT+02:00 Michael Niedermayer : > ffmpeg/libavcodec/arm/blockdsp_arm.h:24:6: note: previous declaration of > ‘ff_blockdsp_init_neon’ was here Missed that header... I can only find those using grep... Here's an updated patch. -- Christophe From 8da8a89ecf33e0c550fa61d6423a

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Michael Niedermayer
On Mon, Sep 28, 2015 at 06:51:07PM +0200, Christophe Gisquet wrote: > This parameter is intended for pixel data, while the functions are > actually only called for dct blocks. > > I admit I haven't run this over all of fate, so it would be nice to > validate nothing actually uses it for pixels (I

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Ronald S. Bultje
Hi, On Thu, Oct 1, 2015 at 9:26 AM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > 2015-10-01 14:40 GMT+02:00 Ronald S. Bultje : > > bash-3.2$ grep ff_pixblockdsp_init ../libavcodec/* > > ../libavcodec/asvenc.c:ff_pixblockdsp_init(&a->pdsp, avctx); > > ../libavcodec/avdct.c:

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Christophe Gisquet
2015-10-01 14:40 GMT+02:00 Ronald S. Bultje : > bash-3.2$ grep ff_pixblockdsp_init ../libavcodec/* > ../libavcodec/asvenc.c:ff_pixblockdsp_init(&a->pdsp, avctx); > ../libavcodec/avdct.c:ff_pixblockdsp_init(&pdsp, avctx); > ../libavcodec/dnxhdenc.c:ff_pixblockdsp_init(&ctx->m.pdsp, a

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Ronald S. Bultje
Hi, On Thu, Oct 1, 2015 at 8:28 AM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > 2015-09-28 18:51 GMT+02:00 Christophe Gisquet < > christophe.gisq...@gmail.com>: > > I admit I haven't run this over all of fate, so it would be nice to > > validate nothing actually uses it for pixels

Re: [FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-10-01 Thread Christophe Gisquet
2015-09-28 18:51 GMT+02:00 Christophe Gisquet : > I admit I haven't run this over all of fate, so it would be nice to > validate nothing actually uses it for pixels (I have see nothing of > the sort). Passes fate-video fate-vcodec on Win64. -- Christophe _

[FFmpeg-devel] [PATCH] blockdsp: remove high bit depth parameter

2015-09-28 Thread Christophe Gisquet
This parameter is intended for pixel data, while the functions are actually only called for dct blocks. I admit I haven't run this over all of fate, so it would be nice to validate nothing actually uses it for pixels (I have see nothing of the sort). -- Christophe From d89cdcaf4f71bcb910e57184c2