Re: [FFmpeg-devel] [PATCH] configure - add dependencies for MPEG-PS and MPEG-ES demuxers

2018-01-31 Thread Gyan Doshi
On 2/1/2018 1:34 AM, James Almer wrote: No comment about the demuxer selecting demuxer line. That's usually only done when they both share pretty much the exact same code. In this case, if the mpegvideo demuxer isn't enabled, the PS demuxer sends the video stream to the MPEG audio decoder

Re: [FFmpeg-devel] [PATCH] configure - add dependencies for MPEG-PS and MPEG-ES demuxers

2018-01-31 Thread James Almer
On 1/31/2018 3:20 PM, Hendrik Leppkes wrote: > On Wed, Jan 31, 2018 at 6:22 PM, Gyan Doshi wrote: >> >> On 1/31/2018 10:18 PM, Carl Eugen Hoyos wrote: >>> >>> >>> While this would help me personally, I don't think it is correct: >>> Many such examples exist, I believe the

Re: [FFmpeg-devel] [PATCH] configure - add dependencies for MPEG-PS and MPEG-ES demuxers

2018-01-31 Thread Gyan Doshi
On 1/31/2018 11:50 PM, Hendrik Leppkes wrote: Anyone who wants a very minimal build needs to configure components very carefully, specifically because of these interactions. In this case, how would a non-dev user go about discovering which components other than the 'obvious' ones are

Re: [FFmpeg-devel] [PATCH] configure - add dependencies for MPEG-PS and MPEG-ES demuxers

2018-01-31 Thread Hendrik Leppkes
On Wed, Jan 31, 2018 at 6:22 PM, Gyan Doshi wrote: > > On 1/31/2018 10:18 PM, Carl Eugen Hoyos wrote: >> >> >> While this would help me personally, I don't think it is correct: >> Many such examples exist, I believe the dependencies are meant to >> ensure compilation, not

Re: [FFmpeg-devel] [PATCH] configure - add dependencies for MPEG-PS and MPEG-ES demuxers

2018-01-31 Thread Gyan Doshi
On 1/31/2018 10:18 PM, Carl Eugen Hoyos wrote: While this would help me personally, I don't think it is correct: Many such examples exist, I believe the dependencies are meant to ensure compilation, not necessarily specific use-cases. Compilation in its own does succeed. And that's the

Re: [FFmpeg-devel] [PATCH] configure - add dependencies for MPEG-PS and MPEG-ES demuxers

2018-01-31 Thread Carl Eugen Hoyos
2018-01-31 11:03 GMT+01:00 Gyan Doshi : > > MPEG-1/2 video streams in MPEG-PS containers fail to be identified unless > the raw MPEG video demuxer is also enabled. Once identified, decoding for > these streams, whether as ES or in PS, isn't error-free unless the mpegvideo >

[FFmpeg-devel] [PATCH] configure - add dependencies for MPEG-PS and MPEG-ES demuxers

2018-01-31 Thread Gyan Doshi
MPEG-1/2 video streams in MPEG-PS containers fail to be identified unless the raw MPEG video demuxer is also enabled. Once identified, decoding for these streams, whether as ES or in PS, isn't error-free unless the mpegvideo parser is enabled. Patch adds these dependencies. MPEG-1/2 videos