Re: [FFmpeg-devel] [PATCH] dashenc: check pts to prevent division by zero error

2020-01-31 Thread Alfred E. Heggestad
On 31/01/2020 14:17, James Almer wrote: On 1/31/2020 10:08 AM, Jeyapal, Karthick wrote: On 1/30/20 3:28 PM, Alfred E. Heggestad wrote: this usecase will cause a division by zero trap: 1. dashenc has received one frame 2. os->max_pts and os->start_pts have same value 3. delta between max_pts

Re: [FFmpeg-devel] [PATCH] dashenc: check pts to prevent division by zero error

2020-01-31 Thread James Almer
On 1/31/2020 10:08 AM, Jeyapal, Karthick wrote: > > On 1/30/20 3:28 PM, Alfred E. Heggestad wrote: >> this usecase will cause a division by zero trap: >> >> 1. dashenc has received one frame >> 2. os->max_pts and os->start_pts have same value >> 3. delta between max_pts and start_pts is 0 >> 4. av

Re: [FFmpeg-devel] [PATCH] dashenc: check pts to prevent division by zero error

2020-01-31 Thread Jeyapal, Karthick
On 1/30/20 3:28 PM, Alfred E. Heggestad wrote: > this usecase will cause a division by zero trap: > > 1. dashenc has received one frame > 2. os->max_pts and os->start_pts have same value > 3. delta between max_pts and start_pts is 0 > 4. av_rescale_q(0, x, y) returns 0 > 5. this value is used as d

[FFmpeg-devel] [PATCH] dashenc: check pts to prevent division by zero error

2020-01-30 Thread Alfred E. Heggestad
this usecase will cause a division by zero trap: 1. dashenc has received one frame 2. os->max_pts and os->start_pts have same value 3. delta between max_pts and start_pts is 0 4. av_rescale_q(0, x, y) returns 0 5. this value is used as denominator in division 6. Bang! -> segfault this fix checks