Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-08 Thread Jeyapal, Karthick
On 3/5/20 9:02 PM, Alfred E. Heggestad wrote: > > > On 05/03/2020 15:37, Carl Eugen Hoyos wrote: >> Am Do., 5. März 2020 um 11:08 Uhr schrieb Alfred E. Heggestad >> : >> >>> -int64_t update_period = c->last_duration / AV_TIME_BASE; >>> +double update_period = (double)c->last_durati

Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Alfred E. Heggestad
On 05/03/2020 15:37, Carl Eugen Hoyos wrote: Am Do., 5. März 2020 um 11:08 Uhr schrieb Alfred E. Heggestad : -int64_t update_period = c->last_duration / AV_TIME_BASE; +double update_period = (double)c->last_duration / AV_TIME_BASE; Can't you instead do int64 update_period =

Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Carl Eugen Hoyos
Am Do., 5. März 2020 um 11:08 Uhr schrieb Alfred E. Heggestad : > -int64_t update_period = c->last_duration / AV_TIME_BASE; > +double update_period = (double)c->last_duration / AV_TIME_BASE; Can't you instead do int64 update_period = last_duration * 1000 / AV_TIME_BASE to avoid us

Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Alfred E. Heggestad
On 05/03/2020 11:40, Moritz Barsnick wrote: On Thu, Mar 05, 2020 at 11:01:19 +0100, Alfred E. Heggestad wrote: -avio_printf(out, "\tsuggestedPresentationDelay=\"PT%"PRId64"S\"\n", c->last_duration / AV_TIME_BASE); +avio_printf(out, "\tsuggestedPresentationDelay=\"PT%.3fS\

Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Moritz Barsnick
On Thu, Mar 05, 2020 at 11:01:19 +0100, Alfred E. Heggestad wrote: > -avio_printf(out, > "\tsuggestedPresentationDelay=\"PT%"PRId64"S\"\n", c->last_duration / > AV_TIME_BASE); > +avio_printf(out, > "\tsuggestedPresentationDelay=\"PT%.3fS\"\n", (double)c->last_duration / > AV

[FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Alfred E. Heggestad
use 3 decimals for the following items: - minBufferTime - minimumUpdatePeriod - timeShiftBufferDepth - suggestedPresentationDelay This improves buffering with shaka player Signed-off-by: Alfred E. Heggestad --- libavformat/dashenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-