Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2024-03-10 Thread Marth64
Thanks, Stefano, I agree it’s not ideal with just having magic numbers. If I think of a creative solution I'll let you know. Appreciate your time, On Sun, Mar 10, 2024 at 09:56 Stefano Sabatini wrote: > On date Saturday 2024-03-09 19:56:49 -0600, Marth64 wrote: > > Following up on this from

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2024-03-10 Thread Stefano Sabatini
On date Saturday 2024-03-09 19:56:49 -0600, Marth64 wrote: > Following up on this from December 2023. I simplified the content and > hopefully addressed the feedback. > > Signed-off-by: Marth64 > --- > doc/bitstream_filters.texi | 15 +++ > 1 file changed, 15 insertions(+) > > diff

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2024-03-09 Thread Marth64
Following up on this from December 2023. I simplified the content and hopefully addressed the feedback. Signed-off-by: Marth64 --- doc/bitstream_filters.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-11 Thread Stefano Sabatini
On date Saturday 2023-12-09 19:35:50 -0600, Marth64 wrote: > --- > doc/bitstream_filters.texi | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index c63c20370f..d2ad6e78ff 100644 > ---

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
Thank you! On Sat, Dec 9, 2023 at 9:06 PM Leo Izen wrote: > On 12/9/23 20:35, Marth64 wrote: > > --- > > doc/bitstream_filters.texi | 18 ++ > > 1 file changed, 18 insertions(+) > > > > Make sure when you generate the second version of a patch with git > format-patch you pass

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Leo Izen
On 12/9/23 20:35, Marth64 wrote: --- doc/bitstream_filters.texi | 18 ++ 1 file changed, 18 insertions(+) Make sure when you generate the second version of a patch with git format-patch you pass the -v2 argument, e.g. git format-patch -v2 -o outgoing/ master Otherwise

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index c63c20370f..d2ad6e78ff 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -213,6 +213,24 @@ To remove all

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
Appreciate the good feedback, will update. Thank you. On Sat, Dec 9, 2023 at 6:53 PM Stefano Sabatini wrote: > On date Saturday 2023-12-09 13:31:13 -0600, Marth64 wrote: > > --- > > doc/bitstream_filters.texi | 17 + > > 1 file changed, 17 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Stefano Sabatini
On date Saturday 2023-12-09 13:31:13 -0600, Marth64 wrote: > --- > doc/bitstream_filters.texi | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index 145aa8684e..b01ede0c93 100644 > ---

[FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Marth64
--- doc/bitstream_filters.texi | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 145aa8684e..b01ede0c93 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @@ -213,6 +213,23 @@ To remove all