Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-10-15 Thread Paul B Mahol
On Fri, Oct 15, 2021 at 6:12 AM Gyan Doshi wrote: > > > On 2021-10-15 12:35 am, Paul B Mahol wrote: > > will revert in next 96 hours. > > Devote time to something productive. > Great words you do not follow at all. > > In any case, not all filters have identical lists. spectrumsynth >

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-10-14 Thread Gyan Doshi
On 2021-10-15 12:35 am, Paul B Mahol wrote: will revert in next 96 hours. Devote time to something productive. In any case, not all filters have identical lists. spectrumsynth supports limited functions. many don't recognize the string 'hann'. The defaults also vary. Harmonize those

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-10-14 Thread Paul B Mahol
will revert in next 96 hours. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-10-02 Thread Paul B Mahol
On Thu, Sep 30, 2021 at 1:04 PM Gyan Doshi wrote: > > > On 2021-09-30 04:28 pm, Paul B Mahol wrote: > > On Thu, Sep 30, 2021 at 12:51 PM Gyan Doshi wrote: > > > >> > >> On 2021-09-30 04:20 pm, Paul B Mahol wrote: > >>> On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi wrote: > >>> > On

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-30 Thread Gyan Doshi
On 2021-09-30 04:28 pm, Paul B Mahol wrote: On Thu, Sep 30, 2021 at 12:51 PM Gyan Doshi wrote: On 2021-09-30 04:20 pm, Paul B Mahol wrote: On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi wrote: On 2021-09-30 02:19 pm, Arif Driessen wrote: Okay. But is it a @chapter Various Windowing

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-30 Thread Paul B Mahol
On Thu, Sep 30, 2021 at 12:51 PM Gyan Doshi wrote: > > > On 2021-09-30 04:20 pm, Paul B Mahol wrote: > > On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi wrote: > > > >> On 2021-09-30 02:19 pm, Arif Driessen wrote: > >>> Okay. But is it a @chapter Various Windowing Functions (placed at the > end >

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-30 Thread Gyan Doshi
On 2021-09-30 04:20 pm, Paul B Mahol wrote: On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi wrote: On 2021-09-30 02:19 pm, Arif Driessen wrote: Okay. But is it a @chapter Various Windowing Functions (placed at the end just before @chapter See Also and @chapter Authors) or a @section Various

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-30 Thread Paul B Mahol
On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi wrote: > > On 2021-09-30 02:19 pm, Arif Driessen wrote: > > Okay. But is it a @chapter Various Windowing Functions (placed at the end > > just before @chapter See Also and @chapter Authors) or a @section Various > > Windowing Functions, that has to

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-30 Thread Gyan Doshi
On 2021-09-30 02:23 pm, Gyan Doshi wrote: On 2021-09-30 02:19 pm, Arif Driessen wrote: Okay. But is it a @chapter Various Windowing Functions (placed at the end just before @chapter See Also and @chapter Authors) or a @section Various Windowing Functions, that has to live under some

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-30 Thread Gyan Doshi
On 2021-09-30 02:19 pm, Arif Driessen wrote: Okay. But is it a @chapter Various Windowing Functions (placed at the end just before @chapter See Also and @chapter Authors) or a @section Various Windowing Functions, that has to live under some chapter? (...Which?) Just keep the current patch

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-30 Thread Arif Driessen
Okay. But is it a @chapter Various Windowing Functions (placed at the end just before @chapter See Also and @chapter Authors) or a @section Various Windowing Functions, that has to live under some chapter? (...Which?) On Wed, Sep 29, 2021 at 8:17 PM Paul B Mahol wrote: > On Wed, Sep 29, 2021 at

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-29 Thread Paul B Mahol
On Wed, Sep 29, 2021 at 7:52 PM Arif Driessen wrote: > > Better add separate section, and than link to it with each filter docs, > instead copy paste lines 100 times. > > If we do add a separate section, I'm not sure where to put it. Perhaps > under "@chapter See Also"? > > I thought about

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-29 Thread Arif Driessen
> Better add separate section, and than link to it with each filter docs, instead copy paste lines 100 times. If we do add a separate section, I'm not sure where to put it. Perhaps under "@chapter See Also"? I thought about something like a "@chapter Common Filter Options", but this makes it

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-29 Thread Paul B Mahol
On Wed, Sep 29, 2021 at 12:51 PM Arif Driessen wrote: > Here's your patch for `afftfilt` win_func. (copied from the surround > filter, but checked against the code to ensure it's correct). If you like > it, I'll do it for all the win_funcs. > Better add separate section, and than link to it

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-29 Thread Arif Driessen
Here's your patch for `afftfilt` win_func. (copied from the surround filter, but checked against the code to ensure it's correct). If you like it, I'll do it for all the win_funcs. --- doc/filters.texi | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Gyan Doshi
On 2021-09-28 07:29 pm, Arif Driessen wrote: These should be formatted like they are in the surround filter for the option with the same name. Good catch! Looking around, I see there are other filters too with a win_func option. When I next get a moment (either later today or more likely

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Arif Driessen
> These should be formatted like they are in the surround filter for the option with the same name. Good catch! Looking around, I see there are other filters too with a win_func option. When I next get a moment (either later today or more likely tomorrow) I'll double check with the code, and add

Re: [FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Gyan Doshi
On 2021-09-28 02:05 pm, Arif Driessen wrote: Hello all, excited about my first patch! Documented the possible window functions for `afftfilt`. Needs review/signing-off. These should be formatted like they are in the surround filter for the option with the same name. ---

[FFmpeg-devel] [PATCH] doc/filters: added possible values to @item win_func

2021-09-28 Thread Arif Driessen
Hello all, excited about my first patch! Documented the possible window functions for `afftfilt`. Needs review/signing-off. --- doc/filters.texi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 0b7e21f7f8..0a04165f11 100644 ---