Re: [FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

Hi, On Tue, May 3, 2016 at 10:21 PM, Michael Niedermayer wrote: > On Tue, May 03, 2016 at 08:58:07PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 3, 2016 at 8:29 PM, Michael Niedermayer > > > wrote: > > > > > On Tue, May 03, 2016 at 03:21:00PM -0400, Ronald S. Bultje wrote: > > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

Hi, On Tue, May 3, 2016 at 10:21 PM, Michael Niedermayer wrote: > On Tue, May 03, 2016 at 08:58:07PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 3, 2016 at 8:29 PM, Michael Niedermayer > > > wrote: > > > > > On Tue, May 03, 2016 at 03:21:00PM -0400, Ronald S. Bultje wrote: > > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

On Wed, May 4, 2016 at 12:44 PM, wm4 wrote: > On Tue, 3 May 2016 15:21:00 -0400 > "Ronald S. Bultje" wrote: > >> I have no idea why the first hunk uses ost->enc_ctx, because as far as >> I understand, that is never used in case of -c:v copy, but this code >> block is only entered if encoding_nee

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

On Tue, 3 May 2016 15:21:00 -0400 "Ronald S. Bultje" wrote: > I have no idea why the first hunk uses ost->enc_ctx, because as far as > I understand, that is never used in case of -c:v copy, but this code > block is only entered if encoding_needed=0, which means stream_copy=1. > My point being: r

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

On Tue, May 03, 2016 at 08:58:07PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, May 3, 2016 at 8:29 PM, Michael Niedermayer > wrote: > > > On Tue, May 03, 2016 at 03:21:00PM -0400, Ronald S. Bultje wrote: > > > I have no idea why the first hunk uses ost->enc_ctx, because as far as > > > I un

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

Hi, On Tue, May 3, 2016 at 8:29 PM, Michael Niedermayer wrote: > On Tue, May 03, 2016 at 03:21:00PM -0400, Ronald S. Bultje wrote: > > I have no idea why the first hunk uses ost->enc_ctx, because as far as > > I understand, that is never used in case of -c:v copy, but this code > > block is only

Re: [FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

On Tue, May 03, 2016 at 03:21:00PM -0400, Ronald S. Bultje wrote: > I have no idea why the first hunk uses ost->enc_ctx, because as far as > I understand, that is never used in case of -c:v copy, but this code > block is only entered if encoding_needed=0, which means stream_copy=1. when the code w

[FFmpeg-devel] [PATCH] ffmpeg: copy color properties in case of -c:v copy.

I have no idea why the first hunk uses ost->enc_ctx, because as far as I understand, that is never used in case of -c:v copy, but this code block is only entered if encoding_needed=0, which means stream_copy=1. My point being: review from someone that knows this really well would be appreciated. --