Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-04-01 Thread Jan Ekström
On Sun, Apr 1, 2018 at 1:43 PM, Nicolas George wrote: > > Looks reasonable, thanks. > > Regards, > > -- > Nicolas George > Thanks for the review, pushed. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-04-01 Thread Nicolas George
Jan Ekström (2018-03-31): > With certain types of input and the filter chain getting re-initialized > or re-configured, multiple nullptr AVSubtitles can get pushed into > sub2video_update() in a row from sub2video_heartbeat. > > This causes end_pts, and on the next round pts, to become INT64_MAX,

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-04-01 Thread Paul B Mahol
On 3/31/18, Jan Ekstroem wrote: > With certain types of input and the filter chain getting re-initialized > or re-configured, multiple nullptr AVSubtitles can get pushed into > sub2video_update() in a row from sub2video_heartbeat. > > This causes end_pts, and on the next round pts, to become INT64

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-31 Thread Jan Ekström
On Sat, Mar 31, 2018 at 8:09 PM, Jan Ekström wrote: > With certain types of input and the filter chain getting re-initialized > or re-configured, multiple nullptr AVSubtitles can get pushed into > sub2video_update() in a row from sub2video_heartbeat. > > This causes end_pts, and on the next round

[FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-31 Thread Jan Ekström
With certain types of input and the filter chain getting re-initialized or re-configured, multiple nullptr AVSubtitles can get pushed into sub2video_update() in a row from sub2video_heartbeat. This causes end_pts, and on the next round pts, to become INT64_MAX, latter of which signals EOF in frame

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-30 Thread Jan Ekström
On Thu, Mar 29, 2018 at 5:25 PM, Jan Ekström wrote: > On Thu, Mar 29, 2018 at 1:14 PM, Michael Niedermayer > wrote: >> >> this breaks fate-sub2video >> >> TESTsub2video >> --- ./tests/ref/fate/sub2video 2018-03-29 02:30:48.095578219 +0200 >> +++ tests/data/fate/sub2video 2018-03-29 12:13:2

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-29 Thread Jan Ekström
On Thu, Mar 29, 2018 at 1:14 PM, Michael Niedermayer wrote: > > this breaks fate-sub2video > > TESTsub2video > --- ./tests/ref/fate/sub2video 2018-03-29 02:30:48.095578219 +0200 > +++ tests/data/fate/sub2video 2018-03-29 12:13:25.191428538 +0200 > @@ -68,7 +68,8 @@ > 0,258,

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-29 Thread Michael Niedermayer
On Thu, Mar 29, 2018 at 12:53:18AM +0300, Jan Ekström wrote: > From: Jan Ekström > > With some streams multiple nullptr AVSubtitles can get pushed > into sub2video_update() in a row. > > This causes end_pts, and on the next round pts, to become > INT64_MAX, latter of which signals EOF in framesy

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-28 Thread Jan Ekström
On Thu, Mar 29, 2018 at 12:53 AM, Jan Ekström wrote: > From: Jan Ekström > > With some streams multiple nullptr AVSubtitles can get pushed > into sub2video_update() in a row. > > This causes end_pts, and on the next round pts, to become > INT64_MAX, latter of which signals EOF in framesync, leadi

[FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-28 Thread Jan Ekström
From: Jan Ekström With some streams multiple nullptr AVSubtitles can get pushed into sub2video_update() in a row. This causes end_pts, and on the next round pts, to become INT64_MAX, latter of which signals EOF in framesync, leading to complete loss of subtitles from that point on. Thus, utiliz