Re: [FFmpeg-devel] [PATCH] ffplay: fix autoexit doesn't work in the case of pb->error

2020-09-08 Thread Marton Balint
On Mon, 7 Sep 2020, Zhao Zhili wrote: On Aug 27, 2020, at 4:20 PM, Marton Balint wrote: On Thu, 27 Aug 2020, Zhao Zhili wrote: --- Goto fail will make ffplay exit immediately. I'm not sure it is the expected behavior. How about just remove the check on pb->error so decoders can drain

Re: [FFmpeg-devel] [PATCH] ffplay: fix autoexit doesn't work in the case of pb->error

2020-09-06 Thread Zhao Zhili
> On Aug 27, 2020, at 4:20 PM, Marton Balint wrote: > > > > On Thu, 27 Aug 2020, Zhao Zhili wrote: > >> --- >> Goto fail will make ffplay exit immediately. I'm not sure >> it is the expected behavior. How about just remove the >> check on pb->error so decoders can drain normally? > > I thin

Re: [FFmpeg-devel] [PATCH] ffplay: fix autoexit doesn't work in the case of pb->error

2020-08-27 Thread Marton Balint
On Thu, 27 Aug 2020, Zhao Zhili wrote: --- Goto fail will make ffplay exit immediately. I'm not sure it is the expected behavior. How about just remove the check on pb->error so decoders can drain normally? I think it is fine as is, if we simply ignored the error, then looping would start a

[FFmpeg-devel] [PATCH] ffplay: fix autoexit doesn't work in the case of pb->error

2020-08-26 Thread Zhao Zhili
--- Goto fail will make ffplay exit immediately. I'm not sure it is the expected behavior. How about just remove the check on pb->error so decoders can drain normally? fftools/ffplay.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c