Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: properly initialize output stream field order

On 26.04.2018 16:06, Tobias Rapp wrote: Fixes stream field order written by avformat_write_header when "top" option is specified on the command-line. Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 6 ++ 1 file changed, 6 insertions(+) [...] Pushed, thanks

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: properly initialize output stream field order

On Thu, Apr 26, 2018 at 04:06:27PM +0200, Tobias Rapp wrote: > Fixes stream field order written by avformat_write_header when "top" > option is specified on the command-line. > > Signed-off-by: Tobias Rapp > --- > fftools/ffmpeg.c | 6 ++ > 1 file changed, 6

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: properly initialize output stream field order

On 4/26/2018 3:49 PM, Tobias Rapp wrote: > "ost" is of type OutputStream here, which only has top_field_first with > values auto=-1/bff=0/tff=1. AVFrame has the > interlaced_frame/top_field_first pair you mentioned, while > AVCodecContext has field_order. Ah, I misunderstood the type and

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: properly initialize output stream field order

On 26.04.2018 16:11, Derek Buitenhuis wrote: On 4/26/2018 3:06 PM, Tobias Rapp wrote: +if (ost->top_field_first == 0) { +enc_ctx->field_order = AV_FIELD_BB; +} else if (ost->top_field_first == 1) { +enc_ctx->field_order = AV_FIELD_TT; +} This

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: properly initialize output stream field order

On 4/26/2018 3:06 PM, Tobias Rapp wrote: > +if (ost->top_field_first == 0) { > +enc_ctx->field_order = AV_FIELD_BB; > +} else if (ost->top_field_first == 1) { > +enc_ctx->field_order = AV_FIELD_TT; > +} This doesn't look correct;

[FFmpeg-devel] [PATCH] fftools/ffmpeg: properly initialize output stream field order

Fixes stream field order written by avformat_write_header when "top" option is specified on the command-line. Signed-off-by: Tobias Rapp --- fftools/ffmpeg.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index