Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: rename read_file() to avoid conflict with libass

2022-10-20 Thread Anton Khirnov
Quoting Rémi Denis-Courmont (2022-10-20 10:06:45) > `file_read` is just as likely to cause naming conflicts. And I have > seen really insane libraries with no namespacing getting preloaded, so > it is unfortunately not even only a problem with libraries that FFmpeg > links with. > > If you're

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: rename read_file() to avoid conflict with libass

2022-10-20 Thread Rémi Denis-Courmont
Le 20 octobre 2022 10:12:28 GMT+03:00, Anton Khirnov a écrit : >libass defines a non-static read_file() symbol, which causes conflicts >with static linking. >--- > fftools/ffmpeg.h | 2 +- > fftools/ffmpeg_mux_init.c | 4 ++-- > fftools/ffmpeg_opt.c | 4 ++-- > 3 files changed, 5

[FFmpeg-devel] [PATCH] fftools/ffmpeg: rename read_file() to avoid conflict with libass

2022-10-20 Thread Anton Khirnov
libass defines a non-static read_file() symbol, which causes conflicts with static linking. --- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_mux_init.c | 4 ++-- fftools/ffmpeg_opt.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.h