Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-10 Thread Alex Converse
On Thu, May 10, 2018 at 4:08 PM, Jan Ekström wrote: > On Fri, May 11, 2018 at 1:39 AM, Alex Converse > wrote: >> On Thu, May 3, 2018 at 10:58 AM, Jan Ekström wrote: >>> >>> Hi, >>> >>> While the timestamp field is 8+24=32 bits, the DTS value is int64_ts. >>> Thus, while I'm really bad at doing

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-10 Thread Jan Ekström
On Fri, May 11, 2018 at 1:48 AM, Alex Converse wrote: > > Sorry about the lateness on my part. Were there any later comments. I > haven't seen any. (And yes I can push this myself when all the > concerns are resolved). It's OK, it has been a rather busy time for me as well. I was already thinkin

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-10 Thread Jan Ekström
On Fri, May 11, 2018 at 1:39 AM, Alex Converse wrote: > On Thu, May 3, 2018 at 10:58 AM, Jan Ekström wrote: >> >> Hi, >> >> While the timestamp field is 8+24=32 bits, the DTS value is int64_ts. >> Thus, while I'm really bad at doing wrap-around logic, wouldn't it be >> something a la ´uint32_t wr

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-10 Thread Alex Converse
On Fri, May 4, 2018 at 7:11 AM, Josh de Kock wrote: > >> On 4 May 2018, at 12:26, Michael Niedermayer wrote: >> >>> On Fri, May 04, 2018 at 11:03:20AM +0800, Steven Liu wrote: >>> >>> On 4 May 2018, at 02:00, Jan Ekström wrote: On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: >

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-10 Thread Alex Converse
On Thu, May 3, 2018 at 10:58 AM, Jan Ekström wrote: > > On Thu, May 3, 2018 at 7:50 PM, Alex Converse wrote: > > From: Alex Converse > > > > --- > > libavformat/flvenc.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/libavformat/flvenc.c b/libavformat/

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-04 Thread Josh de Kock
> On 4 May 2018, at 12:26, Michael Niedermayer wrote: > >> On Fri, May 04, 2018 at 11:03:20AM +0800, Steven Liu wrote: >> >> >>> On 4 May 2018, at 02:00, Jan Ekström wrote: >>> >>> On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: On Thu, May 3, 2018 at 7:50 PM, Alex Converse w

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-04 Thread wm4
On Fri, 4 May 2018 17:31:52 +0800 Steven Liu wrote: > > On 4 May 2018, at 17:20, Jan Ekström wrote: > > > > WHAT!? > > > > This LGTM was for the bit mask *only* > > > > ALL OTHER POINTS STAND > > Don’t worry , all LGTM too, this could fix the resend sequence header > timestamp problem, al

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-04 Thread Michael Niedermayer
On Fri, May 04, 2018 at 11:03:20AM +0800, Steven Liu wrote: > > > > On 4 May 2018, at 02:00, Jan Ekström wrote: > > > > On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: > >> On Thu, May 3, 2018 at 7:50 PM, Alex Converse > >> wrote: [...] > Will apply. I think Alex Converse has a git writ

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-04 Thread Steven Liu
> On 4 May 2018, at 17:20, Jan Ekström wrote: > > WHAT!? > > This LGTM was for the bit mask *only* > > ALL OTHER POINTS STAND Don’t worry , all LGTM too, this could fix the resend sequence header timestamp problem, all should be ok. > > Jan Thanks Steven ___

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-04 Thread Jan Ekström
WHAT!? This LGTM was for the bit mask *only* ALL OTHER POINTS STAND Jan On Fri, May 4, 2018, 06:04 Steven Liu wrote: > > > > On 4 May 2018, at 02:00, Jan Ekström wrote: > > > > On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: > >> On Thu, May 3, 2018 at 7:50 PM, Alex Converse > wrote: >

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Steven Liu
> On 4 May 2018, at 02:00, Jan Ekström wrote: > > On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: >> On Thu, May 3, 2018 at 7:50 PM, Alex Converse >> wrote: >>> From: Alex Converse >>> >>> --- >>> libavformat/flvenc.c | 10 +- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Jan Ekström
On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: > On Thu, May 3, 2018 at 7:50 PM, Alex Converse wrote: >> From: Alex Converse >> >> --- >> libavformat/flvenc.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c >

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Jan Ekström
On Thu, May 3, 2018 at 7:50 PM, Alex Converse wrote: > From: Alex Converse > > --- > libavformat/flvenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c > index e8af48cb64..827d798a61 100644 > --- a/libavformat/flve

[FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Alex Converse
From: Alex Converse --- libavformat/flvenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index e8af48cb64..827d798a61 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -480,7 +480,7 @@ static int unsuppo