Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

On Sun, Aug 10, 2014 at 05:58:19PM +0200, Mickaël Raulet wrote: > Hi > Le 10 août 2014 à 15:48, Michael Niedermayer a écrit : > > > On Sun, Aug 10, 2014 at 03:16:23PM +0200, Christophe Gisquet wrote: > >> Hi, > >> > >> 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje : > >>> Are we using the checked

Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

Hi Le 10 août 2014 à 15:48, Michael Niedermayer a écrit : > On Sun, Aug 10, 2014 at 03:16:23PM +0200, Christophe Gisquet wrote: >> Hi, >> >> 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje : >>> Are we using the checked bitstream reader? If we are, we're fine already... >> >> I think we are. On the

Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

Hi Le 10 août 2014 à 15:16, Christophe Gisquet a écrit : > Hi, > > 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje : >> Are we using the checked bitstream reader? If we are, we're fine already... > > I think we are. On the other hand, it seems the top caller, > ff_hevc_decode_nal_vps, is never ch

Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

On Sun, Aug 10, 2014 at 03:16:23PM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje : > > Are we using the checked bitstream reader? If we are, we're fine already... > > I think we are. On the other hand, it seems the top caller, > ff_hevc_decode_nal_vps, is

Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

Hi, 2014-08-10 14:42 GMT+02:00 Ronald S. Bultje : > Are we using the checked bitstream reader? If we are, we're fine already... I think we are. On the other hand, it seems the top caller, ff_hevc_decode_nal_vps, is never checking if we have read past the bitstream end. Shouldn't this be checked a

Re: [FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

Hi, On Sun, Aug 10, 2014 at 6:04 AM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > Hi, > > the attached patch is a half-baked attempt at checking the input. I > suspect there are a lot of places where little to no validation is > performed anyway. > > Maybe it would be wise to mark

[FFmpeg-devel] [PATCH] hevc_ps: verify P/T/L information

Hi, the attached patch is a half-baked attempt at checking the input. I suspect there are a lot of places where little to no validation is performed anyway. Maybe it would be wise to mark hevc as experimental for now ? -- Christophe From 65030ebd08fabce851698fa1024a042fc994ef18 Mon Sep 17 00:00