Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-13 Thread Andreas Cadhalpun
On 13.10.2015 04:21, Michael Niedermayer wrote: > On Mon, Oct 12, 2015 at 08:15:10PM +0200, Andreas Cadhalpun wrote: >> It seems several headers are intended to be installed, but actually aren't: > >> libavutil/des.h: >> av_des_alloc >> av_des_crypt >> av_des_init >> av_des_mac >> libavutil/rc

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-12 Thread James Almer
On 10/12/2015 3:15 PM, Andreas Cadhalpun wrote: > On 11.10.2015 23:37, James Almer wrote: >> On 10/11/2015 6:26 PM, Andreas Cadhalpun wrote: >>> Anyway, please also remove the entry for av_ctz from APIchanges. >>> It's not public API, so it never belonged there. >> >> Huh, even an APIChanges line?

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-12 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 08:15:10PM +0200, Andreas Cadhalpun wrote: > On 11.10.2015 23:37, James Almer wrote: > > On 10/11/2015 6:26 PM, Andreas Cadhalpun wrote: > >> Anyway, please also remove the entry for av_ctz from APIchanges. > >> It's not public API, so it never belonged there. > > > > Huh,

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-12 Thread Andreas Cadhalpun
On 11.10.2015 23:37, James Almer wrote: > On 10/11/2015 6:26 PM, Andreas Cadhalpun wrote: >> Anyway, please also remove the entry for av_ctz from APIchanges. >> It's not public API, so it never belonged there. > > Huh, even an APIChanges line? Wonder if intmath.h was public at some > point, or if

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 7:45 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Oct 12, 2015 at 7:12 AM, Ganesh Ajjanagadde > wrote: > >> On Mon, Oct 12, 2015 at 6:30 AM, Michael Niedermayer >> wrote: >> > On Sun, Oct 11, 2015 at 10:02:29PM -0400, Ronald S. Bultje wrote: >> >> Hi, >> >> >> >> On Sun,

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-12 Thread Ronald S. Bultje
Hi, On Mon, Oct 12, 2015 at 7:12 AM, Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 6:30 AM, Michael Niedermayer > wrote: > > On Sun, Oct 11, 2015 at 10:02:29PM -0400, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Sun, Oct 11, 2015 at 9:17 PM, Ganesh Ajjanagadde > >> wrote: > >> > >> > On

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 6:30 AM, Michael Niedermayer wrote: > On Sun, Oct 11, 2015 at 10:02:29PM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Oct 11, 2015 at 9:17 PM, Ganesh Ajjanagadde >> wrote: >> >> > On Sun, Oct 11, 2015 at 9:12 PM, Ganesh Ajjanagadde >> > wrote: >> > > On Sun, Oct 11

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-12 Thread Michael Niedermayer
On Sun, Oct 11, 2015 at 10:02:29PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Oct 11, 2015 at 9:17 PM, Ganesh Ajjanagadde > wrote: > > > On Sun, Oct 11, 2015 at 9:12 PM, Ganesh Ajjanagadde > > wrote: > > > On Sun, Oct 11, 2015 at 6:04 PM, Ronald S. Bultje > > wrote: > > >> Hi, > > >> > >

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ronald S. Bultje
Hi, On Sun, Oct 11, 2015 at 9:17 PM, Ganesh Ajjanagadde wrote: > On Sun, Oct 11, 2015 at 9:12 PM, Ganesh Ajjanagadde > wrote: > > On Sun, Oct 11, 2015 at 6:04 PM, Ronald S. Bultje > wrote: > >> Hi, > >> > >> On Sun, Oct 11, 2015 at 5:52 PM, Andreas Cadhalpun < > >> andreas.cadhal...@googlemail

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ganesh Ajjanagadde
On Sun, Oct 11, 2015 at 9:38 PM, Timothy Gu wrote: > On Sun, Oct 11, 2015 at 6:31 PM Ganesh Ajjanagadde wrote: > >> Just to make this clear: suppose (hypothetically) av_ctz was public. >> If my application never used av_ctz, but I (or my distro) upgrades >> libav*, then I don't need to recompile/

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Timothy Gu
On Sun, Oct 11, 2015 at 6:31 PM Ganesh Ajjanagadde wrote: > Just to make this clear: suppose (hypothetically) av_ctz was public. > If my application never used av_ctz, but I (or my distro) upgrades > libav*, then I don't need to recompile/relink my code? > If we are only talking about av_ctz her

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ganesh Ajjanagadde
On Sun, Oct 11, 2015 at 9:24 PM, James Almer wrote: > On 10/11/2015 10:12 PM, Ganesh Ajjanagadde wrote: >> On Sun, Oct 11, 2015 at 6:04 PM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Sun, Oct 11, 2015 at 5:52 PM, Andreas Cadhalpun < >>> andreas.cadhal...@googlemail.com> wrote: >>> On 11.10.2

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ganesh Ajjanagadde
On Sun, Oct 11, 2015 at 9:24 PM, James Almer wrote: > On 10/11/2015 10:12 PM, Ganesh Ajjanagadde wrote: >> On Sun, Oct 11, 2015 at 6:04 PM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Sun, Oct 11, 2015 at 5:52 PM, Andreas Cadhalpun < >>> andreas.cadhal...@googlemail.com> wrote: >>> On 11.10.2

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread James Almer
On 10/11/2015 10:12 PM, Ganesh Ajjanagadde wrote: > On Sun, Oct 11, 2015 at 6:04 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Oct 11, 2015 at 5:52 PM, Andreas Cadhalpun < >> andreas.cadhal...@googlemail.com> wrote: >> >>> On 11.10.2015 23:44, Ronald S. Bultje wrote: It's a non-installed h

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ganesh Ajjanagadde
On Sun, Oct 11, 2015 at 9:12 PM, Ganesh Ajjanagadde wrote: > On Sun, Oct 11, 2015 at 6:04 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Oct 11, 2015 at 5:52 PM, Andreas Cadhalpun < >> andreas.cadhal...@googlemail.com> wrote: >> >>> On 11.10.2015 23:44, Ronald S. Bultje wrote: >>> > It's a non-

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ganesh Ajjanagadde
On Sun, Oct 11, 2015 at 6:04 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Oct 11, 2015 at 5:52 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 11.10.2015 23:44, Ronald S. Bultje wrote: >> > It's a non-installed header and only used in one place (flacenc). >> > Since ff_

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ronald S. Bultje
Hi, On Sun, Oct 11, 2015 at 5:52 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 11.10.2015 23:44, Ronald S. Bultje wrote: > > It's a non-installed header and only used in one place (flacenc). > > Since ff_ctz is static inline, it's fine to use that instead. > > --- > > doc

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Andreas Cadhalpun
On 11.10.2015 23:44, Ronald S. Bultje wrote: > It's a non-installed header and only used in one place (flacenc). > Since ff_ctz is static inline, it's fine to use that instead. > --- > doc/APIchanges | 3 --- > libavcodec/flacenc.c | 2 +- > libavutil/intmath.c | 5 - > libavutil/int

[FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ronald S. Bultje
It's a non-installed header and only used in one place (flacenc). Since ff_ctz is static inline, it's fine to use that instead. --- doc/APIchanges | 3 --- libavcodec/flacenc.c | 2 +- libavutil/intmath.c | 5 - libavutil/intmath.h | 14 ++ 4 files changed, 7 insertions(

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread James Almer
On 10/11/2015 6:26 PM, Andreas Cadhalpun wrote: > Anyway, please also remove the entry for av_ctz from APIchanges. > It's not public API, so it never belonged there. Huh, even an APIChanges line? Wonder if intmath.h was public at some point, or if whoever added this wasn't aware it was an internal

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Andreas Cadhalpun
On 11.10.2015 20:28, Ronald S. Bultje wrote: > It's an a non-installed header and only used in one place (flacenc). ^ This 'an' should not be there. > Since ff_ctz is static inline, it's fine to use that instead. > --- > libavcodec/flacenc.c | 2 +- > libavutil/intmath.c | 5 - > liba

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread James Almer
On 10/11/2015 4:16 PM, Timothy Gu wrote: > On Sun, Oct 11, 2015 at 11:29 AM Ronald S. Bultje > wrote: > >> It's an a non-installed header and only used in one place (flacenc). >> Since ff_ctz is static inline, it's fine to use that instead. >> --- >> libavcodec/flacenc.c | 2 +- >> libavutil/int

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Timothy Gu
On Sun, Oct 11, 2015 at 11:29 AM Ronald S. Bultje wrote: > It's an a non-installed header and only used in one place (flacenc). > Since ff_ctz is static inline, it's fine to use that instead. > --- > libavcodec/flacenc.c | 2 +- > libavutil/intmath.c | 5 - > libavutil/intmath.h | 8 --

[FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-11 Thread Ronald S. Bultje
It's an a non-installed header and only used in one place (flacenc). Since ff_ctz is static inline, it's fine to use that instead. --- libavcodec/flacenc.c | 2 +- libavutil/intmath.c | 5 - libavutil/intmath.h | 8 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/liba