Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-27 Thread Alexander Strasser
Hi Stephan! On 2019-03-25 20:32 +0100, Stephan Hilb wrote: > Alexander Strasser wrote on 21.03.2019 at 23:34: > > > 3. Return zero-sized packets => This works and is consistent with how > >we handle frames flagged to be corrupted (V4L2_BUF_FLAG_ERROR). > >See commit

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-25 Thread Stephan Hilb
Alexander Strasser wrote on 21.03.2019 at 23:34: > 3. Return zero-sized packets => This works and is consistent with how >we handle frames flagged to be corrupted (V4L2_BUF_FLAG_ERROR). >See commit 28f20d2ff487aa589643d8f70eaf614b78839685 . I posted a patch for this on Sat, 25 Aug 2018.

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-21 Thread Alexander Strasser
Hi Marton, hi Nicolas! On 2019-03-21 10:07 +0100, Nicolas George wrote: > Marton Balint (12019-03-21): > > Maybe just set the packet corrupt flag and log an error, but return the > > partial buffer? > > I think it may be the best solution. But it would be interesting to know > how the tools react

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-21 Thread Nicolas George
Marton Balint (12019-03-21): > Maybe just set the packet corrupt flag and log an error, but return the > partial buffer? I think it may be the best solution. But it would be interesting to know how the tools react to it. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-20 Thread Marton Balint
On Wed, 20 Mar 2019, Carl Eugen Hoyos wrote: 2019-03-20 22:26 GMT+01:00, Alexander Strasser : Hi all! On 2019-03-20 19:56 +0100, Alexander Strasser wrote: I had found that when capturing video for some hours from USB Camera-B4.09.24.1 (Manufacturer: OmniVision Technologies, Inc.),

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-20 Thread Carl Eugen Hoyos
2019-03-20 22:26 GMT+01:00, Alexander Strasser : > Hi all! > > On 2019-03-20 19:56 +0100, Alexander Strasser wrote: >> I had found that when capturing video for some hours from >> USB Camera-B4.09.24.1 (Manufacturer: OmniVision Technologies, Inc.), >> sometimes when invoking the ioctl DQBUF, the

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-20 Thread Alexander Strasser
Hi all! On 2019-03-20 19:56 +0100, Alexander Strasser wrote: > I had found that when capturing video for some hours from > USB Camera-B4.09.24.1 (Manufacturer: OmniVision Technologies, Inc.), > sometimes when invoking the ioctl DQBUF, the returned buffer is not > filled with the size we expect

[FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-20 Thread Alexander Strasser
I had found that when capturing video for some hours from USB Camera-B4.09.24.1 (Manufacturer: OmniVision Technologies, Inc.), sometimes when invoking the ioctl DQBUF, the returned buffer is not filled with the size we expect for the raw video frame. Here are two examples for such occurrences: