Re: [FFmpeg-devel] [PATCH] lavd: deprecate SDL device

2016-09-10 Thread Paul B Mahol
On 9/10/16, Carl Eugen Hoyos wrote: > 2016-09-10 21:53 GMT+02:00 Josh de Kock : > >> +if ! enabled sdl; then >> +disable sdl_outdev >> +fi > > This is not necessary: > You can remove the device anytime after deprecating it, no > need to disable it by default. > >> +av_log(s, AV_LOG_WARNING

Re: [FFmpeg-devel] [PATCH] lavd: deprecate SDL device

2016-09-10 Thread Carl Eugen Hoyos
2016-09-10 21:53 GMT+02:00 Josh de Kock : > +if ! enabled sdl; then > +disable sdl_outdev > +fi This is not necessary: You can remove the device anytime after deprecating it, no need to disable it by default. > +av_log(s, AV_LOG_WARNING, "The SDL output device is deprecated.\n"); This i

[FFmpeg-devel] [PATCH] lavd: deprecate SDL device

2016-09-10 Thread Josh de Kock
SDL1 has been unmaintained for quite a while (version 1.2.15 was released 4 years ago). Due to how SDL2 works (it requires the main thread), there won't be able to be a replacement to the SDL avdevice if ffplay were to switch to SDL2 in the future. This commit would also help in getting ffplay to s