Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-12 Thread Dale Curtis
On Tue, Nov 12, 2019 at 1:27 AM Carl Eugen Hoyos wrote: > > Breaks AVIFS files > > that were previously demuxing as mp4 w/ video track, > > Does it only break them once above change was made or also in the existing > patch? > (Sorry, I am still travelling in Japan without computer.) > Only after

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-12 Thread Carl Eugen Hoyos
> Am 12.11.2019 um 09:09 schrieb Dale Curtis : > >> On Fri, Nov 1, 2019 at 4:46 PM Carl Eugen Hoyos wrote: >> >> Testing would be helpful. >> >> > Works for AVIF after adding the line I proposed as well as setting > codecpar->width/height for the stream based on ispe. Great! > Breaks AVIFS

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-11 Thread Dale Curtis
On Fri, Nov 1, 2019 at 4:46 PM Carl Eugen Hoyos wrote: > Testing would be helpful. > > Works for AVIF after adding the line I proposed as well as setting codecpar->width/height for the stream based on ispe. Breaks AVIFS files that were previously demuxing as mp4 w/ video track, i.e., https://gith

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-01 Thread Carl Eugen Hoyos
Am Do., 31. Okt. 2019 um 18:30 Uhr schrieb Dale Curtis : > > On Thu, Oct 31, 2019 at 1:32 AM Swaraj Hota wrote: > > > Yes I will send the patch soon for review. Still a few things left to do. > > > > Swaraj > > > > Great! Let me know if there's anything I can help with. Testing would be helpful.

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-01 Thread Dale Curtis
On Fri, Nov 1, 2019 at 4:14 AM Swaraj Hota wrote: > Sure. Thanks for the samples! > I have not currently tested the patch with avif format, was only focused on > heif. But as the only difference is the decoder (?), this support could be > easily added. I'll try to add it but as I have been workin

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-01 Thread Swaraj Hota
On Thu, Oct 31, 2019, 11:00 PM Dale Curtis wrote: > On Thu, Oct 31, 2019 at 1:32 AM Swaraj Hota > wrote: > > > Yes I will send the patch soon for review. Still a few things left to do. > > > > Swaraj > > > > Great! Let me know if there's anything I can help with. If you need some > AVIF samples

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-10-31 Thread Dale Curtis
On Thu, Oct 31, 2019 at 1:32 AM Swaraj Hota wrote: > Yes I will send the patch soon for review. Still a few things left to do. > > Swaraj > Great! Let me know if there's anything I can help with. If you need some AVIF samples they can be found here: https://github.com/AOMediaCodec/av1-avif/tree/

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-10-31 Thread Swaraj Hota
On Thu, Oct 31, 2019, 4:39 AM Dale Curtis wrote: > On Wed, Oct 30, 2019 at 1:17 PM Carl Eugen Hoyos > wrote: > > > https://github.com/Swaraj1998/FFmpeg > > > > (Roger's patch sadly did not work with real-world files) > > > Thanks Carl! That patch looks good. I'll test it out. Is Swaraj still > p

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-10-30 Thread Dale Curtis
On Wed, Oct 30, 2019 at 1:17 PM Carl Eugen Hoyos wrote: > https://github.com/Swaraj1998/FFmpeg > > (Roger's patch sadly did not work with real-world files) Thanks Carl! That patch looks good. I'll test it out. Is Swaraj still planning to send that for review later? - dale _

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-10-30 Thread Carl Eugen Hoyos
Am Mi., 30. Okt. 2019 um 21:05 Uhr schrieb Dale Curtis : > > Was there a reason this never landed? I sympathize with the complexity of > the format, but since AVIF has adopted it as well, it'd be nice to have > ffmpeg support. Feel free to test this tree: https://github.com/Swaraj1998/FFmpeg (Rog

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-10-30 Thread Dale Curtis
Was there a reason this never landed? I sympathize with the complexity of the format, but since AVIF has adopted it as well, it'd be nice to have ffmpeg support. - dale On Sat, Aug 19, 2017 at 2:40 AM Carl Eugen Hoyos wrote: > 2017-08-19 9:24 GMT+02:00 Rodger Combs : > > > AVInputFormat ff_mov

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2017-08-19 Thread Carl Eugen Hoyos
2017-08-19 9:24 GMT+02:00 Rodger Combs : > AVInputFormat ff_mov_demuxer = { > -.name = "mov,mp4,m4a,3gp,3g2,mj2", > +.name = "mov,mp4,m4a,3gp,3g2,mj2,heif,heic", Since it isn't necessary for the new feature: Please don't change this line. Carl Eugen _

[FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2017-08-19 Thread Rodger Combs
There's a decent chance this doesn't work on [pretty much anything other than the samples I tested it with], but I haven't found very many samples, and don't want to implement the rest of the features blind with nothing but a spec, and most of it's pretty over-the-top anyway. For some reason my ph