Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-10 Thread Michael Niedermayer
On Thu, Nov 10, 2016 at 01:27:51PM +, Derek Buitenhuis wrote: > On 11/9/2016 6:51 PM, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c | 41 > > tests/fate/mov.mak | 6 +- > > tests/ref/fate/mp4-init-nonkeyframe

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-10 Thread Derek Buitenhuis
On 11/9/2016 6:51 PM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c | 41 > tests/fate/mov.mak | 6 +- > tests/ref/fate/mp4-init-nonkeyframe | 120 > > 3 files changed, 155 inserti

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-09 Thread Sasi Inguva
I've modified the patch to fallback to rounding edit list media time to zero when it is negative, and added a strict_std_compliance check for edit lists. PTAL. Thanks. On Sun, Nov 6, 2016 at 7:07 PM, Derek Buitenhuis wrote: > On 11/6/2016 12:40 PM, Michael Niedermayer wrote: > > IMO we should su

[FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-09 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/mov.c | 41 tests/fate/mov.mak | 6 +- tests/ref/fate/mp4-init-nonkeyframe | 120 3 files changed, 155 insertions(+), 12 deletions(-) create mode 100644 tests/ref/fa

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-06 Thread Derek Buitenhuis
On 11/6/2016 12:40 PM, Michael Niedermayer wrote: > IMO we should support it if its possible without large hacks I don't really have an opinion myself, so to speak. I was just noting it. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-06 Thread Michael Niedermayer
On Sun, Nov 06, 2016 at 10:08:23AM +0530, Sasi Inguva wrote: > When I play the file using Quicktime Player 7 , it errs out saying "invalid > public movie atom found" . Quicktime 10.4 shows a black screen . Even vlc > doesn't play the video. It's true that it used to work before, but don't > know i

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-05 Thread Sasi Inguva
When I play the file using Quicktime Player 7 , it errs out saying "invalid public movie atom found" . Quicktime 10.4 shows a black screen . Even vlc doesn't play the video. It's true that it used to work before, but don't know if we need to support it. On Sat, Nov 5, 2016 at 10:25 PM, Derek Buit

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-05 Thread Derek Buitenhuis
On 11/4/2016 9:53 PM, Sasi Inguva wrote: > So, if I am not wrong, the only case when that would happen is, if edit > list media time was < 0 . And that would be a corrupt MOV file, unless edit > list media time = -1. > I tried to create such a file with AtomInspector but it doesn't let me. FWIW, t

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-04 Thread Sasi Inguva
So, if I am not wrong, the only case when that would happen is, if edit list media time was < 0 . And that would be a corrupt MOV file, unless edit list media time = -1. I tried to create such a file with AtomInspector but it doesn't let me. On Fri, Nov 4, 2016 at 10:05 AM, Derek Buitenhuis < dere

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-04 Thread Derek Buitenhuis
On 11/3/2016 10:36 PM, Sasi Inguva wrote: > +if (index == -1) { > +av_log(mov->fc, AV_LOG_ERROR, > + "st: %d edit list %"PRId64" Cannot find an index > entry before timestamp: %"PRId64"\n", > + st->index, edit_list_index, sear

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-03 Thread Michael Niedermayer
On Fri, Nov 04, 2016 at 12:12:44AM +0100, Michael Niedermayer wrote: > On Thu, Nov 03, 2016 at 03:36:02PM -0700, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c | 30 ++--- > > tests/fate/mov.mak | 6 +- > > > tests/ref/fa

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-03 Thread Sasi Inguva
Actually my messages are awaiting moderation approval because the file is too big (1.5 MB). I am giving this drive link https://drive.google.com/file/d/0Bz6XfEJZ-9N3aVYtS0tIMFRVZmM/view?usp=sharing On Thu, Nov 3, 2016 at 4:12 PM, Michael Niedermayer wrote: > On Thu, Nov 03, 2016 at 03:36:02PM

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-03 Thread Michael Niedermayer
On Thu, Nov 03, 2016 at 03:36:02PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c | 30 ++--- > tests/fate/mov.mak | 6 +- > tests/ref/fate/mp4-init-nonkeyframe | 120 > wheres the s

[FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-03 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/mov.c | 30 ++--- tests/fate/mov.mak | 6 +- tests/ref/fate/mp4-init-nonkeyframe | 120 3 files changed, 145 insertions(+), 11 deletions(-) create mode 100644 tests/ref/fate/

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-03 Thread Sasi Inguva
Sorry, forgot to add the fate test reference file. Sending it again. On Thu, Nov 3, 2016 at 12:41 PM, Sasi Inguva wrote: > Attaching the fate sample. > > On Thu, Nov 3, 2016 at 12:39 PM, Sasi Inguva wrote: > >> Signed-off-by: Sasi Inguva >> --- >> libavformat/mov.c | 30 -

[FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2016-11-03 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/mov.c | 30 -- tests/fate/mov.mak | 6 +- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 4222088..f5b2035 100644 --- a/libavformat/mov.c +++ b/libavformat/mov