Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-09 Thread Sasi Inguva
That's great. Thanks. On Jun 9, 2017 9:24 AM, "wm4" wrote: > On Tue, 6 Jun 2017 11:16:01 -0700 > Sasi Inguva wrote: > > > Fixes t/6421. If the videos starts with B frame, then the minimum > composition time as computed by stts + ctts will be non-zero. Hence we need > to shift the DTS, so that

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-09 Thread wm4
On Tue, 6 Jun 2017 11:16:01 -0700 Sasi Inguva wrote: > Fixes t/6421. If the videos starts with B frame, then the minimum composition > time as computed by stts + ctts will be non-zero. Hence we need to shift the > DTS, so that the first pts is zero. This was the intention of that > code-block

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-08 Thread wm4
On Thu, 8 Jun 2017 12:28:41 -0700 Sasi Inguva wrote: > Ping! > If nobody has another comment, I guess I can push it tomorrow or next week. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-08 Thread Sasi Inguva
Ping! On Jun 6, 2017 11:17 AM, "Sasi Inguva" wrote: > Got it. Added to the description. > > On Tue, Jun 6, 2017 at 6:51 AM, wm4 wrote: > >> On Sat, 3 Jun 2017 19:31:37 -0700 >> Sasi Inguva wrote: >> >> > > -// Offset the DTS by ctts[0] to make the PTS of the first frame 0 >> > > -if (c

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-06 Thread Sasi Inguva
Got it. Added to the description. On Tue, Jun 6, 2017 at 6:51 AM, wm4 wrote: > On Sat, 3 Jun 2017 19:31:37 -0700 > Sasi Inguva wrote: > > > > -// Offset the DTS by ctts[0] to make the PTS of the first frame 0 > > > -if (ctts_data_old && ctts_count_old > 0) { > > > -edit_list_dts

[FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-06 Thread Sasi Inguva
Fixes t/6421. If the videos starts with B frame, then the minimum composition time as computed by stts + ctts will be non-zero. Hence we need to shift the DTS, so that the first pts is zero. This was the intention of that code-block. However it was subtracting by the wrong amount. For example, f

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-06 Thread wm4
On Sat, 3 Jun 2017 19:31:37 -0700 Sasi Inguva wrote: > > -// Offset the DTS by ctts[0] to make the PTS of the first frame 0 > > -if (ctts_data_old && ctts_count_old > 0) { > > -edit_list_dts_entry_end -= ctts_data_old[0].duration; > > -av_log(mov->fc, AV_LOG_DEBUG, "Offset

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-03 Thread Sasi Inguva
> -// Offset the DTS by ctts[0] to make the PTS of the first frame 0 > -if (ctts_data_old && ctts_count_old > 0) { > -edit_list_dts_entry_end -= ctts_data_old[0].duration; > -av_log(mov->fc, AV_LOG_DEBUG, "Offset DTS by ctts[%d].duration: %d\n", 0, ctts_data_old[0].duration)

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-03 Thread wm4
On Fri, 2 Jun 2017 18:17:22 -0700 Sasi Inguva wrote: > Fixes t/6421 > > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c| 57 -- > tests/ref/fate/h264-twofields-packet | 60 > ++-- > 2 files changed, 70 i

[FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-02 Thread Sasi Inguva
Fixes t/6421 Signed-off-by: Sasi Inguva --- libavformat/mov.c| 57 -- tests/ref/fate/h264-twofields-packet | 60 ++-- 2 files changed, 70 insertions(+), 47 deletions(-) diff --git a/libavformat/mov.c b/libavform