Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
>I don't think it's good to have the default behaviour destroy the original >timestamps. Okay, I don't modify this timebase on correctly encoded videos (99.5% of my collection, and probably 100% of YouTube collection). Only on the few videos with problematic timebase I modify it, and there is a w

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
On 11/10/2016 16:47, Alexey Eromenko wrote: So, in which cases a large timebase would help ? Okay, I have allowed to manually over-ride the auto-detect setting via -video_track_timescale parameter, if someone really knows what he's doing. But the default settings (after my patch) work fine, with

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
So, in which cases a large timebase would help ? Okay, I have allowed to manually over-ride the auto-detect setting via -video_track_timescale parameter, if someone really knows what he's doing. But the default settings (after my patch) work fine, with Windows Media Player, Quicktime, iTunes and V

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
In which cases a large timebase would help ? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Clément Bœsch
On Tue, Oct 11, 2016 at 05:16:30PM +0200, Alexey Eromenko wrote: > GMail disallows me to paste unwrapped text, so I will use good-old > pastebin plain text. > > http://pastebin.com/SPUF4NTS No, please fix or learn how to use your mailer. BTW, what if I actually want/need a large timebase because

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
GMail disallows me to paste unwrapped text, so I will use good-old pastebin plain text. http://pastebin.com/SPUF4NTS ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 02:40:57PM +0200, Alexey Eromenko wrote: > I have written a different patch, which should auto-fix the problem, > but I can't compile and test it now (due to build system issues): > movenc.c affects both MP4 and MOV containers, right ? > > > > --- ./movenc.c.orig

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
I have written a different patch, which should auto-fix the problem, but I can't compile and test it now (due to build system issues): movenc.c affects both MP4 and MOV containers, right ? --- ./movenc.c.orig 2016-10-11 06:24:44.328730759 -0400 +++ ./ffmpeg-3.1.3/ffmpeg-3.1.3/libavformat

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
Josh, thanks for your efforts. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
Also the patch needs to cover both MP4 and MOV containers. On Tue, Oct 11, 2016 at 1:49 PM, Moritz Barsnick wrote: > On Tue, Oct 11, 2016 at 12:30:30 +0100, Josh de Kock wrote: >> "WARNING codec timebase is very high. If duration is >> too long,\n" >>

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 12:30:30 +0100, Josh de Kock wrote: > "WARNING codec timebase is very high. If duration is > too long,\n" > "file may not be playable by quicktime. Specify a > shorter timebase\n" > - "or choose differen

[FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
Fixes ticket #5882. While it doesn't automatically set the timescale for the user as that would destroy data without prompt, it will tell the user how they could set the timescale (as this is mostly likely what they want). Signed-off-by: Josh de Kock --- libavformat/movenc.c | 4 +++- 1 file cha