Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Limin Wang
On Mon, Jul 08, 2019 at 01:52:16PM +0200, Moritz Barsnick wrote: > On Mon, Jul 08, 2019 at 18:48:46 +0800, lance.lmw...@gmail.com wrote: > > +@item keep_dar > > +stack with 1/nb_inputs of each inputs screen to keep the same DAR, Default > > is 0. > ^ > Probably "i

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Paul B Mahol
>> >> Keep DAR of which input i.e. what if the inputs have different DARs? > > I'm using it for comparing two same video quality, it's not general > for all condition anyway. > >> >> The user can already emulate this by cropping inputs befoehand. > Yes, we can use the crop filter to get the same fu

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Limin Wang
On Mon, Jul 08, 2019 at 05:44:06PM +0530, Gyan wrote: > > > On 08-07-2019 04:18 PM, lance.lmw...@gmail.com wrote: > >From: Limin Wang > > > >It's useful to compare two 4K videos quality side by side on 4K TV. > > > >Signed-off-by: Limin Wang > >--- > > doc/filters.texi | 6 ++ > > l

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Paul B Mahol
Not acceptable patch. Please do not merge. On 7/8/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > It's useful to compare two 4K videos quality side by side on 4K TV. > > Signed-off-by: Limin Wang > --- > doc/filters.texi | 6 ++ > libavfilter/vf_stack.c | 31 ++

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Gyan
On 08-07-2019 04:18 PM, lance.lmw...@gmail.com wrote: From: Limin Wang It's useful to compare two 4K videos quality side by side on 4K TV. Signed-off-by: Limin Wang --- doc/filters.texi | 6 ++ libavfilter/vf_stack.c | 31 ++- 2 files changed, 32 i

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Moritz Barsnick
On Mon, Jul 08, 2019 at 18:48:46 +0800, lance.lmw...@gmail.com wrote: > +@item keep_dar > +stack with 1/nb_inputs of each inputs screen to keep the same DAR, Default > is 0. ^ Probably "input's". Is screen the correct term here at all? (In three places in the patc

[FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread lance . lmwang
From: Limin Wang It's useful to compare two 4K videos quality side by side on 4K TV. Signed-off-by: Limin Wang --- doc/filters.texi | 6 ++ libavfilter/vf_stack.c | 31 ++- 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/doc/filters.texi b