Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-08 Thread Moritz Barsnick
On Sat, Jun 06, 2020 at 11:42:17 +0530, gautamr...@gmail.com wrote: > +static uint8_t info_marker(uint16_t marker) Usually ffmpeg uses type int as a replacement for bool (but I'm not sure on this). > +else > +if (marker > 0xFF00) return 1; > +return 0; Should be else if (m

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-06 Thread James Almer
On 6/6/2020 8:06 PM, Michael Niedermayer wrote: > On Sat, Jun 06, 2020 at 11:42:17AM +0530, gautamr...@gmail.com wrote: >> From: Gautam Ramakrishnan >> >> I have attempted to write a JPEG2000 Parser. Have tested >> by generating a file containing 14 frames, as mentioned >> by Micheal. Have also tr

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-06 Thread Michael Niedermayer
On Sat, Jun 06, 2020 at 11:42:17AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > I have attempted to write a JPEG2000 Parser. Have tested > by generating a file containing 14 frames, as mentioned > by Micheal. Have also tried testing with various packet > sizes by setting -fr

[FFmpeg-devel] [PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-05 Thread gautamramk
From: Gautam Ramakrishnan I have attempted to write a JPEG2000 Parser. Have tested by generating a file containing 14 frames, as mentioned by Micheal. Have also tried testing with various packet sizes by setting -frame_size option. Additionally, fixed a few formatting issues as pointed out by Mic