Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-05 Thread Nicolas George
Le sextidi 16 prairial, an CCXXV, Daniel Kučera a écrit : > Ok, I see only suggestions and ideas here. If you have any exact > request for change in my patch, let me know. I am not your foreman or anything like that, it is not my place to order you around. What I can tell you is that patches

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-04 Thread Daniel Kučera
2017-06-04 12:25 GMT+02:00 Nicolas George : > Le sextidi 16 prairial, an CCXXV, Daniel Kucera a écrit : >> Signed-off-by: Daniel Kucera >> --- >> libavformat/avio.c| 2 +- >> libavformat/aviobuf.c | 20 >> libavformat/cache.c

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-04 Thread Nicolas George
Le sextidi 16 prairial, an CCXXV, Daniel Kucera a écrit : > Signed-off-by: Daniel Kucera > --- > libavformat/avio.c| 2 +- > libavformat/aviobuf.c | 20 > libavformat/cache.c | 4 ++-- > libavformat/file.c| 2 ++ > libavformat/subfile.c

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-04 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavformat/aviobuf.c | 20 libavformat/cache.c | 4 ++-- libavformat/file.c| 2 ++ libavformat/subfile.c | 2 +- libavformat/wtvdec.c | 4 ++-- 6 files changed, 20

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread James Almer
On 6/3/2017 6:11 PM, Daniel Kučera wrote: > 2017-06-03 23:04 GMT+02:00 James Almer : >> On 6/3/2017 5:31 PM, Daniel Kučera wrote: >>> 2017-06-03 21:54 GMT+02:00 Michael Niedermayer : On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote:

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Daniel Kučera
2017-06-03 23:04 GMT+02:00 James Almer : > On 6/3/2017 5:31 PM, Daniel Kučera wrote: >> 2017-06-03 21:54 GMT+02:00 Michael Niedermayer : >>> On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: Signed-off-by: Daniel Kucera

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread James Almer
On 6/3/2017 5:31 PM, Daniel Kučera wrote: > 2017-06-03 21:54 GMT+02:00 Michael Niedermayer : >> On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: >>> Signed-off-by: Daniel Kucera >>> --- >>> libavformat/avio.c| 2 +- >>>

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavformat/aviobuf.c | 20 libavformat/cache.c | 2 +- libavformat/file.c| 2 ++ libavformat/subfile.c | 2 +- libavformat/wtvdec.c | 4 ++-- 6 files changed, 19

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Daniel Kučera
2017-06-03 21:54 GMT+02:00 Michael Niedermayer : > On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: >> Signed-off-by: Daniel Kucera >> --- >> libavformat/avio.c| 2 +- >> libavformat/aviobuf.c | 18 ++ >>

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Michael Niedermayer
On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/avio.c| 2 +- > libavformat/aviobuf.c | 18 ++ > libavformat/cache.c | 2 +- > libavformat/file.c| 2 ++ > libavformat/subfile.c

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Michael Niedermayer
On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/avio.c| 2 +- > libavformat/aviobuf.c | 18 ++ > libavformat/cache.c | 2 +- > libavformat/file.c| 2 ++ > libavformat/subfile.c

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavformat/aviobuf.c | 18 ++ libavformat/cache.c | 2 +- libavformat/file.c| 2 ++ libavformat/subfile.c | 2 +- libavformat/wtvdec.c | 4 ++-- 6 files changed, 17 insertions(+),

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Daniel Kučera
2017-06-03 8:58 GMT+02:00 Daniel Kučera : >> >> breaks: >> ffmpeg -i subfile,,start,1,end,40,,:matrixbench_mpeg2.mpg >> subfile.avi >> >> (infnite loop) >> >> > > Where can I get that matrixbench_mpeg2.mpg test file? If I run it > against

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 Thread Daniel Kučera
> > breaks: > ffmpeg -i subfile,,start,1,end,40,,:matrixbench_mpeg2.mpg subfile.avi > > (infnite loop) > > Where can I get that matrixbench_mpeg2.mpg test file? If I run it against fate-suite/mpeg2/matrixbench_mpeg2.lq1.mpg it works: ./ffmpeg -i

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-02 Thread Michael Niedermayer
On Fri, Jun 02, 2017 at 04:55:30PM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/avio.c| 2 +- > libavformat/aviobuf.c | 18 ++ > libavformat/cache.c | 2 +- > libavformat/file.c| 2 ++ > libavformat/wtvdec.c

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-02 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavformat/aviobuf.c | 18 ++ libavformat/cache.c | 2 +- libavformat/file.c| 2 ++ libavformat/wtvdec.c | 4 ++-- 5 files changed, 16 insertions(+), 12 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-02 Thread Daniel Kučera
2017-06-02 15:43 GMT+02:00 Daniel Kučera : > 2017-06-02 15:08 GMT+02:00 Daniel Kučera : >> 2017-06-02 15:02 GMT+02:00 Nicolas George : >>> Le quartidi 14 prairial, an CCXXV, Daniel Kučera a écrit : Now I'm trying to pass fate.

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-02 Thread Daniel Kučera
2017-06-02 15:08 GMT+02:00 Daniel Kučera : > 2017-06-02 15:02 GMT+02:00 Nicolas George : >> Le quartidi 14 prairial, an CCXXV, Daniel Kučera a écrit : >>> Now I'm trying to pass fate. I've fixed some problems but don't have >>> an idea why it won't pass

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-02 Thread Daniel Kučera
2017-06-02 15:02 GMT+02:00 Nicolas George : > Le quartidi 14 prairial, an CCXXV, Daniel Kučera a écrit : >> Now I'm trying to pass fate. I've fixed some problems but don't have >> an idea why it won't pass following test. Does anyone have idea? > > I suspect you need to fix

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-02 Thread Nicolas George
Le quartidi 14 prairial, an CCXXV, Daniel Kučera a écrit : > Now I'm trying to pass fate. I've fixed some problems but don't have > an idea why it won't pass following test. Does anyone have idea? I suspect you need to fix lavf/file.c to actually return AVERROR_EOF. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-02 Thread Daniel Kučera
2017-06-02 3:31 GMT+02:00 Michael Niedermayer : > On Thu, Jun 01, 2017 at 01:12:13PM +0200, Daniel Kucera wrote: >> Signed-off-by: Daniel Kucera >> --- >> libavformat/aviobuf.c | 18 ++ >> 1 file changed, 10 insertions(+), 8

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-01 Thread Michael Niedermayer
On Thu, Jun 01, 2017 at 01:12:13PM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/aviobuf.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) breaks fate (infinte loops) example fate-swr-resample-s32p-2626-8000

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-01 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/aviobuf.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 1667e9f08b..40cff4dc56 100644 --- a/libavformat/aviobuf.c +++