Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-04 Thread Michael Niedermayer
Hi Marvin On Mon, Aug 04, 2014 at 12:51:46AM +0200, Michael Niedermayer wrote: > On Mon, Aug 04, 2014 at 12:24:27AM +0200, Marvin Scholz wrote: > > >av_freep() should be safe to be used with NULL > > > > Since av_freep takes a pointer I am nearly sure that it doesn't, at > > least I remember that

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-03 Thread Michael Niedermayer
On Mon, Aug 04, 2014 at 12:24:27AM +0200, Marvin Scholz wrote: > >av_freep() should be safe to be used with NULL > > Since av_freep takes a pointer I am nearly sure that it doesn't, at > least I remember that I had some issues without the if's… But please > correct me if I'm wrong. in the quoted

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-03 Thread Marvin Scholz
av_freep() should be safe to be used with NULL Since av_freep takes a pointer I am nearly sure that it doesn't, at least I remember that I had some issues without the if's… But please correct me if I'm wrong. ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 11:53:21PM +0200, Marvin Scholz wrote: > >>+if (user) > >>+av_freep(&user); > >>+if (headers) > >>+av_freep(&headers); > > > >pointless ifs > > I'm pretty sure I need it, since there are possible cases where > these are not allocated and I can't free

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-03 Thread Marvin Scholz
+if (user) +av_freep(&user); +if (headers) +av_freep(&headers); pointless ifs I'm pretty sure I need it, since there are possible cases where these are not allocated and I can't free them. ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-02 Thread Clément Bœsch
On Mon, Jul 28, 2014 at 10:36:19AM +0200, epira...@gmail.com wrote: > From: ePirat > > Fix header. Note: you should put that under the --- below so it doesn't end up in the commit description. > --- > Add Icecast protocol, a convenience wrapper for the HTTP protocol > --- > Changelog

[FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-07-28 Thread epirat07
From: ePirat Fix header. --- Add Icecast protocol, a convenience wrapper for the HTTP protocol --- Changelog| 3 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 42 ++ libavformat/Makefile | 1 + libavformat/allfor

[FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-07-28 Thread epirat07
From: ePirat Fix: Last password char was removed by accident. Code cleanup. --- Add Icecast protocol, a convenience wrapper for the HTTP protocol --- Changelog| 3 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 42 ++

[FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-07-23 Thread epirat07
From: ePirat Fixed things. --- Add Icecast protocol, a convenience wrapper for the HTTP protocol --- Changelog| 3 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 42 + libavformat/Makefile | 1 + libavformat/al

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-07-22 Thread Michael Niedermayer
On Wed, Jul 23, 2014 at 02:12:16AM +0200, epira...@gmail.com wrote: > From: ePirat > > Fixed Makefile and micro version > > --- > > Add Icecast protocol, a convenience wrapper for the HTTP protocol > > --- > Changelog| 1 + > configure| 1 + > doc/general.

[FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-07-22 Thread epirat07
From: ePirat Fixed Makefile and micro version --- Add Icecast protocol, a convenience wrapper for the HTTP protocol --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 42 + libavformat/Makefile |

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add icecast protocol

2014-07-22 Thread James Darnley
On 2014-07-23 01:35, epira...@gmail.com wrote: > OBJS-$(CONFIG_HTTPS_PROTOCOL)+= http.o httpauth.o urldecode.o > +OBJS-$(CONFIG_ICECAST_PROTOCOL) += icecast.o > OBJS-$(CONFIG_MMSH_PROTOCOL) += mmsh.o mms.o asf.o These should line up. > + * Icecast p

[FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-07-22 Thread epirat07
From: ePirat Fixed license header --- Add Icecast protocol, a convenience wrapper for the HTTP protocol --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 42 + libavformat/Makefile | 1 + libavf

[FFmpeg-devel] [PATCH] libavformat/icecast.c Add icecast protocol

2014-07-22 Thread epirat07
From: ePirat Here the actual patch, including the icecast.c, forgot to add it to my local git. --- Add Icecast protocol, a convenience wrapper for the HTTP protocol --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi

[FFmpeg-devel] [PATCH] libavformat/icecast.c Add icecast protocol

2014-07-22 Thread epirat07
From: ePirat Add Icecast protocol, a convenience wrapper for the HTTP protocol --- Changelog| 1 + configure| 1 + doc/general.texi | 1 + doc/protocols.texi | 42 ++ libavformat/Makefile | 1 + libavf