Hi Andreas (Rheinhardt) and Reimar,
Thank you for your comments. You're right and the code needs
refactoring.
I prepared a new implementation, please review it:
https://patchwork.ffmpeg.org/patch/13316/
In any case, please note that the software encoder "mpeg2video"
every time writes the
Reimar Döffinger:
> On Wed, May 15, 2019 at 09:39:00AM +, Andreas Rheinhardt wrote:
>>> This problem really needs to be solved. The bitstream generated breaks the
>>> standard!
>>>
>> If I am not mistaken, then the bitstream generated doesn't break the
>> standard; it is just inconvenient for
On Wed, May 15, 2019 at 09:39:00AM +, Andreas Rheinhardt wrote:
> > This problem really needs to be solved. The bitstream generated breaks the
> > standard!
> >
> If I am not mistaken, then the bitstream generated doesn't break the
> standard; it is just inconvenient for streaming purposes.
Hello,
Andreas Håkon:
>
> Hi Andreas,
>
>
>> I know nothing about QSV, but I know a bit about MPEG-2 and have
>> therefore taken a quick look at this:
>
> I'm running a lot of tests with QSV. So I know a little bit about that.
>
>
>> 1.
>>
>>> + if ((p_buf[7] & 0x1)
Hi Andreas,
> I know nothing about QSV, but I know a bit about MPEG-2 and have
> therefore taken a quick look at this:
I'm running a lot of tests with QSV. So I know a little bit about that.
> 1.
>
> > + if ((p_buf[7] & 0x1) == 1) {
> > +
Hello,
Andreas Håkon:
> Hi,
>
> A fix for the missing in-band Sequence Headers from the QSV MPEG-2 HW Encoder.
>
> Regards.
> A.H.
I know nothing about QSV, but I know a bit about MPEG-2 and have
therefore taken a quick look at this:
1.
> +if ((p_buf[7] & 0x1) == 1) {
Hi,
A fix for the missing in-band Sequence Headers from the QSV MPEG-2 HW Encoder.
Regards.
A.H.
---From a0b8525e0ebfd1a3b91bad7a21cc9de5c5a01e0e Mon Sep 17 00:00:00 2001
From: Andreas Hakon
Date: Tue, 14 May 2019 11:07:10 +0100
Subject: [PATCH] libavformat/qsvenc: fix mpeg2 missing headers
