Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Nicolas, On 07/15/2016 02:17 PM, Nicolas George wrote: Therefore I would like to keep the fifo muxer as Jan submitted it, without EAGAIN support. If there is a use case for non-blockingingness in a sense you use the phrase, then it can be added later. I am against it. As it is, I

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Le quintidi 25 messidor, an CCXXIV, Marton Balint a écrit : > Please point me to an application which uses ffmpeg non-blocking mode like > it is supposed to be used. I don't see any muxers wich return EAGAIN, only > protocols, and they only return EAGAIN if AVIO_FLAG_NONBLOCK is set. I > wonder

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

On 07/12/2016 10:28 AM, Nicolas George wrote: Le quintidi 25 messidor, an CCXXIV, Marton Balint a écrit : The fifo muxer never returns EAGAIN. It silently drops the packets in non-blocking mode on a full queue. This behaviour is useful for the tee muxer case, when you don't want one

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

On Tue, 12 Jul 2016, Nicolas George wrote: Le quintidi 25 messidor, an CCXXIV, Marton Balint a écrit : The fifo muxer never returns EAGAIN. It silently drops the packets in non-blocking mode on a full queue. This behaviour is useful for the tee muxer case, when you don't want one

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Le quintidi 25 messidor, an CCXXIV, Marton Balint a écrit : > The fifo muxer never returns EAGAIN. It silently drops the packets in > non-blocking mode on a full queue. This behaviour is useful for the tee > muxer case, when you don't want one slow/unreliable (network) output to > block reading

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

On Mon, 11 Jul 2016, Nicolas George wrote: Le primidi 21 messidor, an CCXXIV, Marton Balint a écrit : The basic goals are the ones which are set in the GSOC trac page under the tee muxer improvement project: Description: FFmpeg contains a tee muxer, which is capable of writing the same coded

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Le primidi 21 messidor, an CCXXIV, Marton Balint a écrit : > The basic goals are the ones which are set in the GSOC trac page under the > tee muxer improvement project: > > Description: FFmpeg contains a tee muxer, which is capable of writing the > same coded packets to multiple outputs. However,

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

On 07/08/2016 10:39 PM, Marton Balint wrote: On Fri, 8 Jul 2016, Nicolas George wrote: Le primidi 21 messidor, an CCXXIV, Jan Sebechlebsky a écrit : I actually thought about this and maybe I am still missing something, but how is this different from the situation without FIFO muxer? It

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

On Fri, 8 Jul 2016, Nicolas George wrote: Le primidi 21 messidor, an CCXXIV, Jan Sebechlebsky a écrit : I actually thought about this and maybe I am still missing something, but how is this different from the situation without FIFO muxer? It is not, which is exactly the answer you do not

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Le primidi 21 messidor, an CCXXIV, Jan Sebechlebsky a écrit : > I actually thought about this and maybe I am still missing something, but > how is this different from the situation without FIFO muxer? It is not, which is exactly the answer you do not want when people ask what your program is good

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Nicolas, On 07/07/2016 08:00 PM, Nicolas George wrote: If your worker thread is blocked on an I/O operation when the application tries to close the muxer, it will send the corresponding messages and call pthread_join(). Since the worker thread is still blocked in the I/O operation, it

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Le primidi 11 messidor, an CCXXIV, Jan Sebechlebsky a écrit : > I don't understand this note - the fifo_format option is used (and seems to > work)? My bad, I did not notice the field had a different name. > Unfortunately :( Do you think cmd muxer initialization could be easily > modified in a

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Moritz, Thanks for feedback and help with grammar! I'll include your fixes in the next version of patch, which I'm planning to send today. On 07/02/2016 08:49 PM, Moritz Barsnick wrote: +#define FIFO_DEFAULT_RECOVERY_WAIT_TIME100 // 1 second You're assigning it as a

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hi, just some formal (non-functional) comments from me. On Tue, Jun 28, 2016 at 13:35:41 +0200, sebechlebsky...@gmail.com wrote: > From: Jan Sebechlebsky > > FIFO pseudo-muxer allows to separate decoder from the > actual output by using first-in-first-out queue and >

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Hello Nicolas, On 06/28/2016 03:42 PM, Nicolas George wrote: +The fifo pseudo-muxer allows to separate encoding from any other muxer +by using first-in-first-out queue and running the actual muxer in separate +thread. This is especially useful in combination with tee muxer +and output to

Re: [FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

Le primidi 11 messidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : > From: Jan Sebechlebsky > > FIFO pseudo-muxer allows to separate decoder from the > actual output by using first-in-first-out queue and > running actual muxer asynchronously in separate thread. >

[FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

From: Jan Sebechlebsky FIFO pseudo-muxer allows to separate decoder from the actual output by using first-in-first-out queue and running actual muxer asynchronously in separate thread. It can be configured to attempt transparent recovery of output on failure.