Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures and AV_FRAME_DATA_ENCODE_INFO AVFrameSideDataType

2019-08-09 Thread James Almer
On 8/9/2019 3:28 PM, Nicolas George wrote: > James Almer (12019-08-09): >> Or just a pointer that points to the first byte after itself. > > The pointer takes places by itself. And it prevents the structure from > being copied flatly, which IIRC is forbidden with side data. Yeah, you're right,

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures and AV_FRAME_DATA_ENCODE_INFO AVFrameSideDataType

2019-08-09 Thread Nicolas George
James Almer (12019-08-09): > Or just a pointer that points to the first byte after itself. The pointer takes places by itself. And it prevents the structure from being copied flatly, which IIRC is forbidden with side data. By the way, the lines of the commit message are too long. Regards, --

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures and AV_FRAME_DATA_ENCODE_INFO AVFrameSideDataType

2019-08-09 Thread James Almer
On 8/9/2019 2:58 PM, Hendrik Leppkes wrote: > On Fri, Aug 9, 2019 at 7:52 PM James Almer wrote: >> >> On 8/9/2019 2:38 PM, Juan De León wrote: >>> AVEncodeInfoFrame data structure to store as AVFrameSideData of type >>> AV_FRAME_DATA_ENCODE_INFO. >>> The structure stores quantization index for

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures and AV_FRAME_DATA_ENCODE_INFO AVFrameSideDataType

2019-08-09 Thread Hendrik Leppkes
On Fri, Aug 9, 2019 at 7:52 PM James Almer wrote: > > On 8/9/2019 2:38 PM, Juan De León wrote: > > AVEncodeInfoFrame data structure to store as AVFrameSideData of type > > AV_FRAME_DATA_ENCODE_INFO. > > The structure stores quantization index for each plane, DC/AC deltas for > > luma and chroma

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures and AV_FRAME_DATA_ENCODE_INFO AVFrameSideDataType

2019-08-09 Thread James Almer
On 8/9/2019 2:38 PM, Juan De León wrote: > AVEncodeInfoFrame data structure to store as AVFrameSideData of type > AV_FRAME_DATA_ENCODE_INFO. > The structure stores quantization index for each plane, DC/AC deltas for luma > and chroma planes, and an array of AVEncodeInfoBlock struct denoting >

[FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures and AV_FRAME_DATA_ENCODE_INFO AVFrameSideDataType

2019-08-09 Thread Juan De León
AVEncodeInfoFrame data structure to store as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO. The structure stores quantization index for each plane, DC/AC deltas for luma and chroma planes, and an array of AVEncodeInfoBlock struct denoting position, size, and delta quantizer for each block

[FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures and AV_FRAME_DATA_ENCODE_INFO AVFrameSideDataType

2019-08-09 Thread Juan De León
AVEncodeInfoFrame data structure to store as AVFrameSideData of type AV_FRAME_DATA_ENCODE_INFO. The structure stores quantization index for each plane, DC/AC deltas for luma and chroma planes, and an array of AVEncodeInfoBlock struct denoting position, size, and delta quantizer for each block