Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-06-09 Thread Neil Birkbeck
On Mon, Jun 8, 2020 at 7:19 AM Tobias Rapp wrote: > On 30.05.2020 12:41, Kieran O Leary wrote: > > Hi, > > > > On Fri 29 May 2020, 22:47 Neil Birkbeck, > wrote: > > > >> [...] > >> I've changed the side data to be PixelCrop (instead of CleanAperture) > given > >> the intent to reuse as cropping

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-06-08 Thread Tobias Rapp
On 30.05.2020 12:41, Kieran O Leary wrote: Hi, On Fri 29 May 2020, 22:47 Neil Birkbeck, wrote: [...] I've changed the side data to be PixelCrop (instead of CleanAperture) given the intent to reuse as cropping elsewhere. -For now, I've kept the rational representation--although CLAP seems to b

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-30 Thread Kieran O Leary
Hi, On Fri 29 May 2020, 22:47 Neil Birkbeck, wrote: > On Mon, May 11, 2020 at 9:37 PM Neil Birkbeck > wrote: > > > > > > > On Wed, May 6, 2020 at 8:45 AM James Almer wrote: > > > >> On 5/6/2020 12:22 PM, Neil Birkbeck wrote: > >> > On Tue, May 5, 2020 at 5:11 AM Kieran O Leary < > kieran.o.le.

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-29 Thread Neil Birkbeck
On Mon, May 11, 2020 at 9:37 PM Neil Birkbeck wrote: > > > On Wed, May 6, 2020 at 8:45 AM James Almer wrote: > >> On 5/6/2020 12:22 PM, Neil Birkbeck wrote: >> > On Tue, May 5, 2020 at 5:11 AM Kieran O Leary > > >> > wrote: >> > >> >> Hi, >> >> >> >> I broke the threading with my last reply, i a

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-11 Thread Neil Birkbeck
On Wed, May 6, 2020 at 8:45 AM James Almer wrote: > On 5/6/2020 12:22 PM, Neil Birkbeck wrote: > > On Tue, May 5, 2020 at 5:11 AM Kieran O Leary > > wrote: > > > >> Hi, > >> > >> I broke the threading with my last reply, i apologise. Here goes another > >> attempt: > >> > >> On Tue, Apr 28, 2020

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-11 Thread Neil Birkbeck
On Thu, May 7, 2020 at 10:21 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Neil Birkbeck: > > On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > > > >> Andreas Rheinhardt (12020-04-28): > >>> That's expected. The patch provided only provides the structure in > which > >>> th

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-07 Thread Andreas Rheinhardt
Neil Birkbeck: > On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > >> Andreas Rheinhardt (12020-04-28): >>> That's expected. The patch provided only provides the structure in which >>> the values are intended to be exported; it does not add any demuxing or >>> muxing capabilities for mov or

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-07 Thread Andreas Rheinhardt
Neil Birkbeck: > On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > >> Andreas Rheinhardt (12020-04-28): >>> That's expected. The patch provided only provides the structure in which >>> the values are intended to be exported; it does not add any demuxing or >>> muxing capabilities for mov or

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-06 Thread James Almer
On 5/6/2020 12:22 PM, Neil Birkbeck wrote: > On Tue, May 5, 2020 at 5:11 AM Kieran O Leary > wrote: > >> Hi, >> >> I broke the threading with my last reply, i apologise. Here goes another >> attempt: >> >> On Tue, Apr 28, 2020 at 6:23 PM Neil Birkbeck >> wrote: >> >>> On Tue, Apr 28, 2020 at 3:1

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-06 Thread Neil Birkbeck
On Tue, May 5, 2020 at 5:11 AM Kieran O Leary wrote: > Hi, > > I broke the threading with my last reply, i apologise. Here goes another > attempt: > > On Tue, Apr 28, 2020 at 6:23 PM Neil Birkbeck > wrote: > > > On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > > > > > Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-05 Thread Kieran O Leary
Hi, I broke the threading with my last reply, i apologise. Here goes another attempt: On Tue, Apr 28, 2020 at 6:23 PM Neil Birkbeck wrote: > On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > > > Andreas Rheinhardt (12020-04-28): > > > That's expected. The patch provided only provides the

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-05 Thread Kieran O Leary
Hi Neil, I have to look deeper into the MKV side of things and most likely raise it with the cellar mailing list so that better minds than mine can weigh in. I do see that the rounding up to 704 could be an issue alright. As for MOV, your patch appears to generate the same output clap values as th

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-28 Thread Neil Birkbeck
On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > Andreas Rheinhardt (12020-04-28): > > That's expected. The patch provided only provides the structure in which > > the values are intended to be exported; it does not add any demuxing or > > muxing capabilities for mov or mkv (as you can see

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-28 Thread Nicolas George
Andreas Rheinhardt (12020-04-28): > That's expected. The patch provided only provides the structure in which > the values are intended to be exported; it does not add any demuxing or > muxing capabilities for mov or mkv (as you can see from the fact that > none of these (de)muxers have been changed

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-28 Thread Andreas Rheinhardt
Kieran O Leary: > Hi Neil, > > Thanks so much for working on this - what was the impetus? > I started the ticket you mentioned. I applied your patch and tested it with > the clap.mov file from that ticket. How do I know if behaviour has changed > with this patch, how should I be testing? > I don't

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-28 Thread Kieran O Leary
Hi Neil, Thanks so much for working on this - what was the impetus? I started the ticket you mentioned. I applied your patch and tested it with the clap.mov file from that ticket. How do I know if behaviour has changed with this patch, how should I be testing? I don't see any reference to the clap

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-28 Thread Neil Birkbeck
On Mon, Apr 27, 2020 at 4:38 AM Lynne wrote: > Apr 27, 2020, 05:27 by neil.birkb...@gmail.com: > > > The clean aperature represents a cropping of the stored image data used > to > > relate the image data to a canonical video system and exists as container > > metadata (see 'clap' section in > htt

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-27 Thread Lynne
Apr 27, 2020, 05:27 by neil.birkb...@gmail.com: > The clean aperature represents a cropping of the stored image data used to > relate the image data to a canonical video system and exists as container > metadata (see 'clap' section in > https://developer.apple.com/library/archive/documentation/Qu

[FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-26 Thread Neil Birkbeck
The clean aperature represents a cropping of the stored image data used to relate the image data to a canonical video system and exists as container metadata (see 'clap' section in https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html) Addition of the side