[FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2019-12-20 Thread Philip Langdale
It can be useful to re-use an encoder instance when doing segmented encodings, and this requires flushing the encoder at the start of each segment. --- libavcodec/nvenc.c | 5 + libavcodec/nvenc.h | 2 ++ libavcodec/nvenc_h264.c | 1 + libavcodec/nvenc_hevc.c | 1 + 4 files changed,

Re: [FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2019-12-20 Thread Josh Allmann
On Fri, 20 Dec 2019 at 15:34, Philip Langdale wrote: > > It can be useful to re-use an encoder instance when doing segmented > encodings, and this requires flushing the encoder at the start of > each segment. > --- > libavcodec/nvenc.c | 5 + > libavcodec/nvenc.h | 2 ++ > libavcode

Re: [FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2019-12-21 Thread Philip Langdale
On Fri, 20 Dec 2019 16:07:18 -0800 Josh Allmann wrote: > One concern I had was about the long-term stability of this behavior. > Right now, it works, but perhaps only coincidentally? Being flushable > and resumable like this isn't explicitly part of the "contract" for > nvenc, as far as I can see

Re: [FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2019-12-30 Thread Philip Langdale
On Sat, 21 Dec 2019 14:54:38 -0800 Philip Langdale wrote: > On Fri, 20 Dec 2019 16:07:18 -0800 > Josh Allmann wrote: > > > One concern I had was about the long-term stability of this > > behavior. Right now, it works, but perhaps only coincidentally? > > Being flushable and resumable like this

Re: [FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2020-01-08 Thread Josh Allmann
On Mon, 30 Dec 2019 at 16:40, Philip Langdale wrote: > > On Sat, 21 Dec 2019 14:54:38 -0800 > Philip Langdale wrote: > > > On Fri, 20 Dec 2019 16:07:18 -0800 > > Josh Allmann wrote: > > > > > One concern I had was about the long-term stability of this > > > behavior. Right now, it works, but per

Re: [FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2020-01-09 Thread Philip Langdale
On Wed, 8 Jan 2020 14:31:05 -0800 Josh Allmann wrote: > > Hi Phil, > > Flushing and resumption is documented/supported in nvenc via > NV_ENC_FLAGS_EOS, but I wasn't sure if this was a feature that > ffmpeg's integration was intentionally designed for. But if you > confirm we can expect this beha