Re: [FFmpeg-devel] [PATCH] pixdesc: Only check against valid entries when iterating over lists of enums

2018-06-10 Thread Derek Buitenhuis
On 09/06/2018 18:31, Michael Niedermayer wrote: > theres no hole in color_range_names > this may lead to static analyzers complaining about dead code v2 sent. I will send a patch to modify the doxygen for the affected enums as well, since I think it's likely downstream users may try to iterate ov

Re: [FFmpeg-devel] [PATCH] pixdesc: Only check against valid entries when iterating over lists of enums

2018-06-10 Thread Derek Buitenhuis
On 10/06/2018 13:27, Derek Buitenhuis wrote: > I will send a patch to modify the doxygen for the affected enums as well, > since I think it's likely downstream users may try to iterate over them > in a similar fashion. Scratch that part, it already is documented, it seems. - Derek ___

Re: [FFmpeg-devel] [PATCH] pixdesc: Only check against valid entries when iterating over lists of enums

2018-06-09 Thread Michael Niedermayer
On Fri, Jun 08, 2018 at 04:47:05PM +0100, Derek Buitenhuis wrote: > Some of these enums have gaps in between their values, since they correspond > to the values in various specs, instead of being an incrementing list. > > Fixes segfaults when, for example, using the valid API call: > >av_colo

[FFmpeg-devel] [PATCH] pixdesc: Only check against valid entries when iterating over lists of enums

2018-06-08 Thread Derek Buitenhuis
Some of these enums have gaps in between their values, since they correspond to the values in various specs, instead of being an incrementing list. Fixes segfaults when, for example, using the valid API call: av_color_primaries_from_name("jecdec-p22"); Signed-off-by: Derek Buitenhuis --- li